Skip to content

Commit

Permalink
Merge pull request #409 from w33ble/agg-builder-values
Browse files Browse the repository at this point in the history
Agg builder values
  • Loading branch information
spenceralger committed Sep 26, 2014
2 parents b58bf21 + 981851f commit 52a8364
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 5 deletions.
5 changes: 3 additions & 2 deletions src/kibana/apps/visualize/editor/agg.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,30 +26,31 @@

<!-- controls !!!actually disabling buttons will break tooltips¡¡¡ -->
<div class="vis-editor-agg-header-controls btn-group">
<!-- up button -->
<button
ng-if="group.length > 1"
ng-class="{ disabled: $first }"
ng-click="moveUp(agg)"
tooltip="Increase Priority"
tooltip-append-to-body="true"

type="button"
class="btn btn-xs btn-default">
<i class="fa fa-caret-up"></i>
</button>

<!-- down button -->
<button
ng-if="group.length > 1"
ng-class="{ disabled: $last }"
ng-click="moveDown(agg)"
tooltip="Decrease Priority"
tooltip-append-to-body="true"

type="button"
class="btn btn-xs btn-default">
<i class="fa fa-caret-down"></i>
</button>

<!-- remove button -->
<button
ng-if="group.length > groupMin"
ng-click="remove(agg)"
Expand Down
1 change: 0 additions & 1 deletion src/kibana/apps/visualize/editor/sidebar.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ define(function (require) {
link: function ($scope) {
$scope.hideErrors = true;
$scope.dontApply = function () {
console.log('showing validation');
$scope.hideErrors = false;
};
}
Expand Down
4 changes: 3 additions & 1 deletion src/kibana/components/agg_types/controls/interval.html
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,7 @@
required
type="number"
class="form-control"
name="interval" />
name="interval"
min="0"
>
</div>
4 changes: 3 additions & 1 deletion src/kibana/components/agg_types/controls/order_and_size.html
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
ng-model="params.size"
required
class="form-control"
type="number">
type="number"
min="0"
>
</div>
</div>

0 comments on commit 52a8364

Please sign in to comment.