Skip to content

Commit

Permalink
Fix spacing in popovers in Rule Detail and Alert Detail as a result o…
Browse files Browse the repository at this point in the history
…f Eui spacing updates (#146144)

Resolves #145987

## Summary

This fixes spacing in the popovers in Rule Detail and Alert Detail
header actions components.

<img width="219" alt="Screenshot 2022-11-23 at 13 09 07"
src="https://user-images.githubusercontent.com/535564/203557408-be09418e-0d6f-4416-bb0f-a301a14138c7.png">
  • Loading branch information
CoenWarmer authored Nov 24, 2022
1 parent ad8373c commit 535d3f8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export function HeaderActions({ alert }: HeaderActionsProps) {
</EuiButton>
}
>
<EuiFlexGroup direction="column" alignItems="flexStart">
<EuiFlexGroup direction="column" alignItems="flexStart" gutterSize="s">
<EuiButtonEmpty
size="s"
color="text"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -308,21 +308,19 @@ export function RuleDetailsPage() {
</EuiButton>
}
>
<EuiFlexGroup direction="column" alignItems="flexStart">
<EuiFlexGroup direction="column" alignItems="flexStart" gutterSize="s">
<EuiButtonEmpty
data-test-subj="editRuleButton"
size="s"
iconType="pencil"
onClick={handleEditRule}
>
<EuiSpacer size="s" />
<EuiText size="s">
{i18n.translate('xpack.observability.ruleDetails.editRule', {
defaultMessage: 'Edit rule',
})}
</EuiText>
</EuiButtonEmpty>
<EuiSpacer size="s" />
<EuiButtonEmpty
size="s"
iconType="trash"
Expand All @@ -336,11 +334,9 @@ export function RuleDetailsPage() {
})}
</EuiText>
</EuiButtonEmpty>
<EuiSpacer size="s" />
</EuiFlexGroup>
</EuiPopover>
</EuiFlexItem>
<EuiSpacer size="s" />
</EuiFlexGroup>,
]
: [],
Expand Down

0 comments on commit 535d3f8

Please sign in to comment.