Skip to content

Commit

Permalink
[osquery] Remove unnecessary ghost colors from EuiBottomBar (#169309
Browse files Browse the repository at this point in the history
)

## Summary

👋 Hey y'all - EUI will shortly be deprecating the `ghost` color in all
button components (see
https://eui.elastic.co/v89.0.0/#/navigation/button#ghost-vs-dark-mode).

In this PR, all components using `color="ghost"` are being used within
an `EuiBottomBar` and as such already automatically inherit dark mode
coloring.

I'm opening this PR ahead of time for your team so you can test this
migration and ensure no UI regressions have occurred as a result.

### Checklist

- [x] Tested in light and dark mode
  • Loading branch information
cee-chen authored Oct 25, 2023
1 parent 7e97dd9 commit 551e4f0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion x-pack/plugins/osquery/public/packs/form/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ const PackFormComponent: React.FC<PackFormProps> = ({
<EuiFlexItem grow={false}>
<EuiFlexGroup gutterSize="m">
<EuiFlexItem grow={false}>
<EuiButtonEmpty color="ghost" {...cancelButtonProps}>
<EuiButtonEmpty color="text" {...cancelButtonProps}>
<FormattedMessage
id="xpack.osquery.pack.form.cancelButtonLabel"
defaultMessage="Cancel"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ const EditSavedQueryFormComponent: React.FC<EditSavedQueryFormProps> = ({
<EuiFlexItem grow={false}>
<EuiFlexGroup gutterSize="m">
<EuiFlexItem grow={false}>
<EuiButtonEmpty color="ghost" {...savedQueryListProps}>
<EuiButtonEmpty color="text" {...savedQueryListProps}>
<FormattedMessage
id="xpack.osquery.editSavedQuery.form.cancelButtonLabel"
defaultMessage="Cancel"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const NewSavedQueryFormComponent: React.FC<NewSavedQueryFormProps> = ({
<EuiFlexItem grow={false}>
<EuiFlexGroup gutterSize="m">
<EuiFlexItem grow={false}>
<EuiButtonEmpty color="ghost" {...savedQueryListProps}>
<EuiButtonEmpty color="text" {...savedQueryListProps}>
<FormattedMessage
id="xpack.osquery.addSavedQuery.form.cancelButtonLabel"
defaultMessage="Cancel"
Expand Down

0 comments on commit 551e4f0

Please sign in to comment.