Skip to content

Commit

Permalink
limit wait time for baselayer (#14047)
Browse files Browse the repository at this point in the history
  • Loading branch information
thomasneirynck authored Oct 4, 2017
1 parent 959eabc commit 5e713df
Showing 1 changed file with 17 additions and 5 deletions.
22 changes: 17 additions & 5 deletions src/core_plugins/tile_map/public/maps_visualization.js
Original file line number Diff line number Diff line change
Expand Up @@ -255,16 +255,28 @@ export function MapsVisualizationProvider(serviceSettings, Notifier, getAppState
};
}

_doRenderComplete(resolve) {
if (this._baseLayerDirty) {//as long as the baselayer is dirty, we cannot fire the render complete event
setTimeout(() => {
this._doRenderComplete(resolve);
}, 10);
_doRenderCompleteWhenBaseLayerIsLoaded(resolve, endTime) {
if (this._baseLayerDirty) {
if (Date.now() <= endTime) {
setTimeout(() => {
this._doRenderCompleteWhenBaseLayerIsLoaded(resolve, endTime);
}, 10);
} else {
//wait time exceeded. If the baselayer cannot load, we will still fire a render-complete.
//This is because slow or unstable network connections cause tiles to get dropped.
//It is unfortunate that tiles get dropped, but we should not drop the render-complete because of it.
resolve();
}
} else {
resolve();
}
}

_doRenderComplete(resolve) {
const msAllowedForBaseLayerToLoad = 10000;
this._doRenderCompleteWhenBaseLayerIsLoaded(resolve, Date.now() + msAllowedForBaseLayerToLoad);
}

addSpatialFilter(agg, filterName, filterData) {
if (!agg) {
return;
Expand Down

0 comments on commit 5e713df

Please sign in to comment.