✅ Fix unit tests + restore right data-test-id

elastic · Jun 8, 2021 · 8ebeede · 8ebeede
1 parent 36b9745
commit 8ebeede
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/x-pack/plugins/lens/public/datatable_visualization/components/dimension_editor.test.tsx b/x-pack/plugins/lens/public/datatable_visualization/components/dimension_editor.test.tsx
@@ -6,7 +6,7 @@
  */
 
 import React from 'react';
-import { EuiButtonGroup, EuiFieldText, EuiSuperSelect } from '@elastic/eui';
+import { EuiButtonGroup, EuiComboBox, EuiFieldText, EuiSuperSelect } from '@elastic/eui';
 import { FramePublicAPI, VisualizationDimensionEditorProps } from '../../types';
 import { DatatableVisualizationState } from '../visualization';
 import { createMockDatasource, createMockFramePublicAPI } from '../../editor_frame_service/mocks';
@@ -227,9 +227,9 @@ describe('data table dimension editor', () => {
     expect(
       instance
         .find('[data-test-subj="lnsDatatable_summaryrow_function"]')
-        .find(EuiSuperSelect)
-        .prop('valueOfSelected')
-    ).toEqual('none');
+        .find(EuiComboBox)
+        .prop('selectedOptions')
+    ).toEqual([{ value: 'none', label: 'None' }]);
 
     expect(instance.find('[data-test-subj="lnsDatatable_summaryrow_label"]').exists()).toBe(false);
   });
@@ -241,9 +241,9 @@ describe('data table dimension editor', () => {
     expect(
       instance
         .find('[data-test-subj="lnsDatatable_summaryrow_function"]')
-        .find(EuiSuperSelect)
-        .prop('valueOfSelected')
-    ).toEqual('sum');
+        .find(EuiComboBox)
+        .prop('selectedOptions')
+    ).toEqual([{ value: 'sum', label: 'Sum' }]);
 
     expect(
       instance

diff --git a/x-pack/plugins/lens/public/datatable_visualization/components/dimension_editor.tsx b/x-pack/plugins/lens/public/datatable_visualization/components/dimension_editor.tsx
@@ -215,7 +215,7 @@ export function TableDimensionEditor(
               fullWidth
               compressed
               isClearable={false}
-              data-test-subj="indexPattern-dimension-field"
+              data-test-subj="lnsDatatable_summaryrow_function"
               placeholder={i18n.translate('xpack.lens.indexPattern.fieldPlaceholder', {
                 defaultMessage: 'Field',
               })}