[ML] Edits to permissions check following review

elastic · Jan 22, 2020 · 901a166 · 901a166
1 parent bde38be
commit 901a166
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 7 deletions.
diff --git a/x-pack/legacy/plugins/ml/public/application/datavisualizer/index_based/page.tsx b/x-pack/legacy/plugins/ml/public/application/datavisualizer/index_based/page.tsx
@@ -132,12 +132,11 @@ export const Page: FC = () => {
 
   const defaults = getDefaultPageState();
 
-  const [showActionsPanel] = useState(
+  const showActionsPanel =
     isFullLicense() &&
-      checkPermission('canCreateJob') &&
-      mlNodesAvailable() &&
-      currentIndexPattern.timeFieldName !== undefined
-  );
+    checkPermission('canCreateJob') &&
+    mlNodesAvailable() &&
+    currentIndexPattern.timeFieldName !== undefined;
 
   const [searchString, setSearchString] = useState(defaults.searchString);
   const [searchQuery, setSearchQuery] = useState(defaults.searchQuery);

diff --git a/x-pack/legacy/plugins/ml/public/application/explorer/explorer.js b/x-pack/legacy/plugins/ml/public/application/explorer/explorer.js
@@ -21,8 +21,11 @@ import {
   EuiFlexItem,
   EuiFormRow,
   EuiIconTip,
+  EuiPage,
+  EuiPageBody,
   EuiSelect,
   EuiSpacer,
+  EuiTitle,
 } from '@elastic/eui';
 
 import { AnnotationFlyout } from '../components/annotations/annotation_flyout';
@@ -87,8 +90,15 @@ function mapSwimlaneOptionsToEuiOptions(options) {
 const ExplorerPage = ({ children, jobSelectorProps, resizeRef }) => (
   <div ref={resizeRef} data-test-subj="mlPageAnomalyExplorer">
     <NavigationMenu tabId="explorer" />
+    <EuiTitle style={{ paddingLeft: '10px', paddingTop: '10px' }}>
+      <h1>
+        <FormattedMessage id="xpack.ml.explorer.pageTitle" defaultMessage="Anomaly explorer" />
+      </h1>
+    </EuiTitle>
     <JobSelector {...jobSelectorProps} />
-    {children}
+    <EuiPage>
+      <EuiPageBody>{children}</EuiPageBody>
+    </EuiPage>
   </div>
 );
 

diff --git a/x-pack/legacy/plugins/ml/public/application/jobs/jobs_list/jobs.tsx b/x-pack/legacy/plugins/ml/public/application/jobs/jobs_list/jobs.tsx
@@ -6,6 +6,7 @@
 
 import React, { FC } from 'react';
 
+import { EuiPage, EuiPageBody } from '@elastic/eui';
 import { NavigationMenu } from '../../components/navigation_menu';
 
 // @ts-ignore
@@ -15,7 +16,11 @@ export const JobsPage: FC<{ props?: any }> = props => {
   return (
     <div data-test-subj="mlPageJobManagement">
       <NavigationMenu tabId="jobs" />
-      <JobsListView {...props} />
+      <EuiPage>
+        <EuiPageBody>
+          <JobsListView {...props} />
+        </EuiPageBody>
+      </EuiPage>
     </div>
   );
 };