Skip to content

Commit

Permalink
Fix loading options tab in goal vis (#43345) (#43657)
Browse files Browse the repository at this point in the history
* Fix loading options tab in goal vis
  • Loading branch information
sulemanof authored Aug 21, 2019
1 parent 6120665 commit 98993f5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ export const vislib = () => ({
defaultMessage: 'Vislib visualization'
}),
args: {
type: {
types: ['string'],
default: '""',
},
visConfig: {
types: ['string', 'null'],
default: '"{}"',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ export const buildPipeline = async (
const visConfig = visState.params;
visConfig.dimensions = await buildVislibDimensions(vis, params);

pipeline += `vislib ${prepareJson('visConfig', visState.params)}`;
pipeline += `vislib type='${vis.type.name}' ${prepareJson('visConfig', visState.params)}`;
} else if (vis.type.toExpression) {
pipeline += await vis.type.toExpression(vis, params);
} else {
Expand Down

0 comments on commit 98993f5

Please sign in to comment.