fix PR review remarks

elastic · Aug 19, 2017 · 9c87c9b · 9c87c9b
1 parent 9726d04
commit 9c87c9b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/core_plugins/kibana/common/field_formats/types/url.js b/src/core_plugins/kibana/common/field_formats/types/url.js
@@ -106,8 +106,8 @@ UrlFormat.prototype._convert = {
           linkLabel = label;
         }
 
-        let linkTarget = this.param('openLinkInCurrentTab') ? '_self' : '_blank';
-          
+        const linkTarget = this.param('openLinkInCurrentTab') ? '_self' : '_blank';
+
         return `<a href="${url}" target="${linkTarget}">${linkLabel}</a>`;
     }
   }

diff --git a/src/ui/public/field_format_editor/editors/url/url.html b/src/ui/public/field_format_editor/editors/url/url.html
@@ -9,8 +9,11 @@
 
 <div class="checkbox" ng-if="editor.formatParams.type == 'a'">
   <label>
-    <input ng-model="editor.formatParams.openLinkInCurrentTab" class="ng-pristine ng-valid ng-touched" type="checkbox">
-    Open link in current tab
+    <input
+      type="checkbox"
+      ng-model="editor.formatParams.openLinkInCurrentTab">
+      Open link in current tab
+    </input>
   </label>
 </div>