Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[8.6] [Discover] Fix Fields flyout and Create Field flyouts on mobile (…
…#145650) (#145789) # Backport This will backport the following commits from `main` to `8.6`: - [[Discover] Fix Fields flyout and Create Field flyouts on mobile (#145650)](#145650) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Constance","email":"constancecchen@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-11-19T06:44:28Z","message":"[Discover] Fix Fields flyout and Create Field flyouts on mobile (#145650)\n\n## Summary\r\n\r\n@jughosta flagged several responsive issues in\r\nhttps://github.com//pull/144845#pullrequestreview-1183919709.\r\nTwo of these were existing issues in Kibana main and need to be\r\nbackported to 8.6, hence the separate PR.\r\n\r\nI recommend turning off whitespace changes when viewing the diff, as\r\nmuch of the wrapped/unwrapped code remained the same except for\r\nindentation.\r\n\r\n### Create Field flyout:\r\n\r\n#### Before:\r\n<img width=\"760\" alt=\"\"\r\nsrc=\"https://user-images.githubusercontent.com/549407/202580476-610e3f54-eabb-4859-a49d-19d0608be787.png\">\r\n\r\n#### After:\r\n<img width=\"779\" alt=\"\"\r\nsrc=\"https://user-images.githubusercontent.com/549407/202580282-886435e7-00cc-4569-943d-fff471b3af7b.png\">\r\n\r\n### Fields flyout (mobile only):\r\n\r\n#### Before:\r\n<img width=\"754\" alt=\"\"\r\nsrc=\"https://user-images.githubusercontent.com/549407/202580465-917ef121-d0eb-4188-bcf7-2b08edb5dd49.png\">\r\n\r\n#### After:\r\n<img width=\"761\" alt=\"\"\r\nsrc=\"https://user-images.githubusercontent.com/549407/202580275-820b9420-a8da-458e-bbb4-5f1cfb57ba99.png\">\r\n\r\n### Checklist\r\n\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>","sha":"10c6649f4b28184fc07d41f081fac7e56c447a50","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v8.6.0","v8.7.0"],"number":145650,"url":"https://github.com/elastic/kibana/pull/145650","mergeCommit":{"message":"[Discover] Fix Fields flyout and Create Field flyouts on mobile (#145650)\n\n## Summary\r\n\r\n@jughosta flagged several responsive issues in\r\nhttps://github.com//pull/144845#pullrequestreview-1183919709.\r\nTwo of these were existing issues in Kibana main and need to be\r\nbackported to 8.6, hence the separate PR.\r\n\r\nI recommend turning off whitespace changes when viewing the diff, as\r\nmuch of the wrapped/unwrapped code remained the same except for\r\nindentation.\r\n\r\n### Create Field flyout:\r\n\r\n#### Before:\r\n<img width=\"760\" alt=\"\"\r\nsrc=\"https://user-images.githubusercontent.com/549407/202580476-610e3f54-eabb-4859-a49d-19d0608be787.png\">\r\n\r\n#### After:\r\n<img width=\"779\" alt=\"\"\r\nsrc=\"https://user-images.githubusercontent.com/549407/202580282-886435e7-00cc-4569-943d-fff471b3af7b.png\">\r\n\r\n### Fields flyout (mobile only):\r\n\r\n#### Before:\r\n<img width=\"754\" alt=\"\"\r\nsrc=\"https://user-images.githubusercontent.com/549407/202580465-917ef121-d0eb-4188-bcf7-2b08edb5dd49.png\">\r\n\r\n#### After:\r\n<img width=\"761\" alt=\"\"\r\nsrc=\"https://user-images.githubusercontent.com/549407/202580275-820b9420-a8da-458e-bbb4-5f1cfb57ba99.png\">\r\n\r\n### Checklist\r\n\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>","sha":"10c6649f4b28184fc07d41f081fac7e56c447a50"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145650","number":145650,"mergeCommit":{"message":"[Discover] Fix Fields flyout and Create Field flyouts on mobile (#145650)\n\n## Summary\r\n\r\n@jughosta flagged several responsive issues in\r\nhttps://github.com//pull/144845#pullrequestreview-1183919709.\r\nTwo of these were existing issues in Kibana main and need to be\r\nbackported to 8.6, hence the separate PR.\r\n\r\nI recommend turning off whitespace changes when viewing the diff, as\r\nmuch of the wrapped/unwrapped code remained the same except for\r\nindentation.\r\n\r\n### Create Field flyout:\r\n\r\n#### Before:\r\n<img width=\"760\" alt=\"\"\r\nsrc=\"https://user-images.githubusercontent.com/549407/202580476-610e3f54-eabb-4859-a49d-19d0608be787.png\">\r\n\r\n#### After:\r\n<img width=\"779\" alt=\"\"\r\nsrc=\"https://user-images.githubusercontent.com/549407/202580282-886435e7-00cc-4569-943d-fff471b3af7b.png\">\r\n\r\n### Fields flyout (mobile only):\r\n\r\n#### Before:\r\n<img width=\"754\" alt=\"\"\r\nsrc=\"https://user-images.githubusercontent.com/549407/202580465-917ef121-d0eb-4188-bcf7-2b08edb5dd49.png\">\r\n\r\n#### After:\r\n<img width=\"761\" alt=\"\"\r\nsrc=\"https://user-images.githubusercontent.com/549407/202580275-820b9420-a8da-458e-bbb4-5f1cfb57ba99.png\">\r\n\r\n### Checklist\r\n\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>","sha":"10c6649f4b28184fc07d41f081fac7e56c447a50"}}]}] BACKPORT--> Co-authored-by: Constance <constancecchen@users.noreply.github.com>
- Loading branch information