[ML] Fix modal titles

elastic · Dec 20, 2022 · a49ee08 · a49ee08
1 parent 7f12906
commit a49ee08
Show file tree

Hide file tree

Showing 18 changed files with 104 additions and 72 deletions.
diff --git a/...on/components/delete_space_aware_item_check_modal/delete_space_aware_item_check_modal.tsx b/...on/components/delete_space_aware_item_check_modal/delete_space_aware_item_check_modal.tsx
@@ -339,10 +339,12 @@ export const DeleteSpaceAwareItemCheckModal: FC<Props> = ({
         <>
           <EuiModalHeader>
             <EuiModalHeaderTitle>
-              <FormattedMessage
-                id="xpack.ml.deleteSpaceAwareItemCheckModal.modalTitle"
-                defaultMessage="Checking space permissions"
-              />
+              <h1>
+                <FormattedMessage
+                  id="xpack.ml.deleteSpaceAwareItemCheckModal.modalTitle"
+                  defaultMessage="Checking space permissions"
+                />
+              </h1>
             </EuiModalHeaderTitle>
           </EuiModalHeader>
 

diff --git a/x-pack/plugins/ml/public/application/components/validate_job/validate_job_view.js b/x-pack/plugins/ml/public/application/components/validate_job/validate_job_view.js
@@ -84,7 +84,9 @@ const LoadingSpinner = () => (
 const Modal = ({ close, title, children }) => (
   <EuiModal onClose={close} style={{ width: '800px' }}>
     <EuiModalHeader>
-      <EuiModalHeaderTitle>{title}</EuiModalHeaderTitle>
+      <EuiModalHeaderTitle>
+        <h1>{title}</h1>
+      </EuiModalHeaderTitle>
     </EuiModalHeader>
 
     <EuiModalBody>{children}</EuiModalBody>

diff --git a/...k/plugins/ml/public/application/explorer/dashboard_controls/add_to_dashboard_controls.tsx b/...k/plugins/ml/public/application/explorer/dashboard_controls/add_to_dashboard_controls.tsx
@@ -81,7 +81,9 @@ export const AddToDashboardControl: FC<AddToDashboardControlProps> = ({
   return (
     <EuiModal onClose={onClose.bind(null, undefined)} data-test-subj="mlAddToDashboardModal">
       <EuiModalHeader>
-        <EuiModalHeaderTitle>{title}</EuiModalHeaderTitle>
+        <EuiModalHeaderTitle>
+          <h1>{title}</h1>
+        </EuiModalHeaderTitle>
       </EuiModalHeader>
       <EuiModalBody>
         {children}

diff --git a/.../public/application/jobs/jobs_list/components/confirm_modals/close_jobs_confirm_modal.tsx b/.../public/application/jobs/jobs_list/components/confirm_modals/close_jobs_confirm_modal.tsx
@@ -87,7 +87,9 @@ export const CloseJobsConfirmModal: FC<Props> = ({
     return (
       <EuiModal data-test-subj="mlCloseJobsConfirmModal" onClose={closeModal}>
         <EuiModalHeader>
-          <EuiModalHeaderTitle>{title}</EuiModalHeaderTitle>
+          <EuiModalHeaderTitle>
+            <h1>{title}</h1>
+          </EuiModalHeaderTitle>
         </EuiModalHeader>
         <EuiModalBody>
           <ManagedJobsWarningCallout

diff --git a/...lic/application/jobs/jobs_list/components/confirm_modals/stop_datafeeds_confirm_modal.tsx b/...lic/application/jobs/jobs_list/components/confirm_modals/stop_datafeeds_confirm_modal.tsx
@@ -88,7 +88,9 @@ export const StopDatafeedsConfirmModal: FC<Props> = ({
     return (
       <EuiModal data-test-subj="mlStopDatafeedsConfirmModal" onClose={closeModal}>
         <EuiModalHeader>
-          <EuiModalHeaderTitle>{title}</EuiModalHeaderTitle>
+          <EuiModalHeaderTitle>
+            <h1>{title}</h1>
+          </EuiModalHeaderTitle>
         </EuiModalHeader>
         <EuiModalBody>
           <ManagedJobsWarningCallout

diff --git a/...ins/ml/public/application/jobs/jobs_list/components/delete_job_modal/delete_job_modal.tsx b/...ins/ml/public/application/jobs/jobs_list/components/delete_job_modal/delete_job_modal.tsx
@@ -87,14 +87,16 @@ export const DeleteJobModal: FC<Props> = ({ setShowFunction, unsetShowFunction,
       <EuiModal data-test-subj="mlDeleteJobConfirmModal" onClose={closeModal}>
         <EuiModalHeader>
           <EuiModalHeaderTitle>
-            <FormattedMessage
-              id="xpack.ml.jobsList.deleteJobModal.deleteJobsTitle"
-              defaultMessage="Delete {jobsCount, plural, one {{jobId}} other {# jobs}}?"
-              values={{
-                jobsCount: jobIds.length,
-                jobId: jobIds[0],
-              }}
-            />
+            <h1>
+              <FormattedMessage
+                id="xpack.ml.jobsList.deleteJobModal.deleteJobsTitle"
+                defaultMessage="Delete {jobsCount, plural, one {{jobId}} other {# jobs}}?"
+                values={{
+                  jobsCount: jobIds.length,
+                  jobId: jobIds[0],
+                }}
+              />
+            </h1>
           </EuiModalHeaderTitle>
         </EuiModalHeader>
         <EuiModalBody>

diff --git a/...gins/ml/public/application/jobs/jobs_list/components/edit_job_flyout/tabs/custom_urls.tsx b/...gins/ml/public/application/jobs/jobs_list/components/edit_job_flyout/tabs/custom_urls.tsx
@@ -288,10 +288,12 @@ class CustomUrlsUI extends Component<CustomUrlsProps, CustomUrlsState> {
       >
         <EuiModalHeader>
           <EuiModalHeaderTitle>
-            <FormattedMessage
-              id="xpack.ml.jobsList.editJobFlyout.customUrls.addCustomUrlButtonLabel"
-              defaultMessage="Add custom URL"
-            />
+            <h1>
+              <FormattedMessage
+                id="xpack.ml.jobsList.editJobFlyout.customUrls.addCustomUrlButtonLabel"
+                defaultMessage="Add custom URL"
+              />
+            </h1>
           </EuiModalHeaderTitle>
         </EuiModalHeader>
 

diff --git a/...ugins/ml/public/application/jobs/jobs_list/components/reset_job_modal/reset_job_modal.tsx b/...ugins/ml/public/application/jobs/jobs_list/components/reset_job_modal/reset_job_modal.tsx
@@ -85,14 +85,16 @@ export const ResetJobModal: FC<Props> = ({ setShowFunction, unsetShowFunction, r
     <EuiModal data-test-subj="mlResetJobConfirmModal" onClose={closeModal}>
       <EuiModalHeader>
         <EuiModalHeaderTitle>
-          <FormattedMessage
-            id="xpack.ml.jobsList.resetJobModal.resetJobsTitle"
-            defaultMessage="Reset {jobsCount, plural, one {{jobId}} other {# jobs}}?"
-            values={{
-              jobsCount: jobIds.length,
-              jobId: jobIds[0],
-            }}
-          />
+          <h1>
+            <FormattedMessage
+              id="xpack.ml.jobsList.resetJobModal.resetJobsTitle"
+              defaultMessage="Reset {jobsCount, plural, one {{jobId}} other {# jobs}}?"
+              values={{
+                jobsCount: jobIds.length,
+                jobId: jobIds[0],
+              }}
+            />
+          </h1>
         </EuiModalHeaderTitle>
       </EuiModalHeader>
       <EuiModalBody>

diff --git a/...public/application/jobs/jobs_list/components/start_datafeed_modal/start_datafeed_modal.js b/...public/application/jobs/jobs_list/components/start_datafeed_modal/start_datafeed_modal.js
@@ -149,14 +149,16 @@ export class StartDatafeedModal extends Component {
         >
           <EuiModalHeader>
             <EuiModalHeaderTitle>
-              <FormattedMessage
-                id="xpack.ml.jobsList.startDatafeedModal.startJobsTitle"
-                defaultMessage="Start {jobsCount, plural, one {{jobId}} other {# jobs}}"
-                values={{
-                  jobsCount: startableJobs.length,
-                  jobId: startableJobs[0].id,
-                }}
-              />
+              <h1>
+                <FormattedMessage
+                  id="xpack.ml.jobsList.startDatafeedModal.startJobsTitle"
+                  defaultMessage="Start {jobsCount, plural, one {{jobId}} other {# jobs}}"
+                  values={{
+                    jobsCount: startableJobs.length,
+                    jobId: startableJobs[0].id,
+                  }}
+                />
+              </h1>
             </EuiModalHeaderTitle>
           </EuiModalHeader>
 

diff --git a/...ion/jobs/new_job/pages/components/datafeed_step/components/data_view/change_data_view.tsx b/...ion/jobs/new_job/pages/components/datafeed_step/components/data_view/change_data_view.tsx
@@ -129,10 +129,12 @@ export const ChangeDataViewModal: FC<Props> = ({ onClose }) => {
       <EuiModal onClose={onClose} data-test-subj="mlJobMgmtImportJobsFlyout">
         <EuiModalHeader>
           <EuiModalHeaderTitle>
-            <FormattedMessage
-              id="xpack.ml.newJob.wizard.datafeedStep.dataView.step0.title"
-              defaultMessage="Change data view"
-            />
+            <h1>
+              <FormattedMessage
+                id="xpack.ml.newJob.wizard.datafeedStep.dataView.step0.title"
+                defaultMessage="Change data view"
+              />
+            </h1>
           </EuiModalHeaderTitle>
         </EuiModalHeader>
 

diff --git a/...ob/pages/components/pick_fields_step/components/advanced_detector_modal/modal_wrapper.tsx b/...ob/pages/components/pick_fields_step/components/advanced_detector_modal/modal_wrapper.tsx
@@ -34,10 +34,12 @@ export const ModalWrapper: FC<Props> = ({ onCreateClick, closeModal, saveEnabled
     >
       <EuiModalHeader>
         <EuiModalHeaderTitle>
-          <FormattedMessage
-            id="xpack.ml.newJob.wizard.pickFieldsStep.advancedDetectorModal.title"
-            defaultMessage="Create detector"
-          />
+          <h1>
+            <FormattedMessage
+              id="xpack.ml.newJob.wizard.pickFieldsStep.advancedDetectorModal.title"
+              defaultMessage="Create detector"
+            />
+          </h1>
         </EuiModalHeaderTitle>
       </EuiModalHeader>
 

diff --git a/x-pack/plugins/ml/public/application/settings/calendars/edit/import_modal/import_modal.js b/x-pack/plugins/ml/public/application/settings/calendars/edit/import_modal/import_modal.js
@@ -147,10 +147,12 @@ export class ImportModal extends Component {
             <EuiFlexGroup direction="column" gutterSize="none">
               <EuiFlexItem grow={false}>
                 <EuiModalHeaderTitle>
-                  <FormattedMessage
-                    id="xpack.ml.calendarsEdit.eventsTable.importEventsTitle"
-                    defaultMessage="Import events"
-                  />
+                  <h1>
+                    <FormattedMessage
+                      id="xpack.ml.calendarsEdit.eventsTable.importEventsTitle"
+                      defaultMessage="Import events"
+                    />
+                  </h1>
                 </EuiModalHeaderTitle>
               </EuiFlexItem>
               <EuiFlexItem grow={false}>

diff --git a/.../plugins/ml/public/application/settings/calendars/edit/new_event_modal/new_event_modal.js b/.../plugins/ml/public/application/settings/calendars/edit/new_event_modal/new_event_modal.js
@@ -266,10 +266,12 @@ export class NewEventModal extends Component {
         >
           <EuiModalHeader>
             <EuiModalHeaderTitle>
-              <FormattedMessage
-                id="xpack.ml.calendarsEdit.newEventModal.createNewEventTitle"
-                defaultMessage="Create new event"
-              />
+              <h1>
+                <FormattedMessage
+                  id="xpack.ml.calendarsEdit.newEventModal.createNewEventTitle"
+                  defaultMessage="Create new event"
+                />
+              </h1>
             </EuiModalHeaderTitle>
           </EuiModalHeader>
 

diff --git a/...ck/plugins/ml/public/application/timeseriesexplorer/components/forecasting_modal/modal.js b/...ck/plugins/ml/public/application/timeseriesexplorer/components/forecasting_modal/modal.js
@@ -33,10 +33,12 @@ export function Modal(props) {
     <EuiModal onClose={props.close} maxWidth={860} data-test-subj="mlModalForecast">
       <EuiModalHeader>
         <EuiModalHeaderTitle>
-          <FormattedMessage
-            id="xpack.ml.timeSeriesExplorer.forecastingModal.forecastingTitle"
-            defaultMessage="Forecasting"
-          />
+          <h1>
+            <FormattedMessage
+              id="xpack.ml.timeSeriesExplorer.forecastingModal.forecastingTitle"
+              defaultMessage="Forecasting"
+            />
+          </h1>
         </EuiModalHeaderTitle>
       </EuiModalHeader>
 

diff --git a/...ck/plugins/ml/public/application/trained_models/models_management/delete_models_modal.tsx b/...ck/plugins/ml/public/application/trained_models/models_management/delete_models_modal.tsx
@@ -69,14 +69,16 @@ export const DeleteModelsModal: FC<DeleteModelsModalProps> = ({ modelIds, onClos
     >
       <EuiModalHeader>
         <EuiModalHeaderTitle>
-          <FormattedMessage
-            id="xpack.ml.trainedModels.modelsList.deleteModal.header"
-            defaultMessage="Delete {modelsCount, plural, one {{modelId}} other {# models}}?"
-            values={{
-              modelId: modelIds[0],
-              modelsCount: modelIds.length,
-            }}
-          />
+          <h1>
+            <FormattedMessage
+              id="xpack.ml.trainedModels.modelsList.deleteModal.header"
+              defaultMessage="Delete {modelsCount, plural, one {{modelId}} other {# models}}?"
+              values={{
+                modelId: modelIds[0],
+                modelsCount: modelIds.length,
+              }}
+            />
+          </h1>
         </EuiModalHeaderTitle>
       </EuiModalHeader>
 

diff --git a/x-pack/plugins/ml/public/application/trained_models/models_management/deployment_setup.tsx b/x-pack/plugins/ml/public/application/trained_models/models_management/deployment_setup.tsx
@@ -289,7 +289,7 @@ export const StartUpdateDeploymentModal: FC<StartDeploymentModalProps> = ({
           <EuiFlexGroup justifyContent={'spaceBetween'}>
             <EuiFlexItem grow={false}>
               <EuiTitle size={'s'}>
-                <h2>
+                <h1>
                   {isUpdate ? (
                     <FormattedMessage
                       id="xpack.ml.trainedModels.modelsList.updateDeployment.modalTitle"
@@ -303,7 +303,7 @@ export const StartUpdateDeploymentModal: FC<StartDeploymentModalProps> = ({
                       values={{ modelId }}
                     />
                   )}
-                </h2>
+                </h1>
               </EuiTitle>
             </EuiFlexItem>
 

diff --git a/x-pack/plugins/ml/public/embeddables/anomaly_charts/anomaly_charts_initializer.tsx b/x-pack/plugins/ml/public/embeddables/anomaly_charts/anomaly_charts_initializer.tsx
@@ -53,12 +53,12 @@ export const AnomalyChartsInitializer: FC<AnomalyChartsInitializerProps> = ({
     >
       <EuiModalHeader>
         <EuiModalHeaderTitle>
-          <h2>
+          <h1>
             <FormattedMessage
               id="xpack.ml.anomalyChartsEmbeddable.setupModal.title"
               defaultMessage="Anomaly explorer charts configuration"
             />
-          </h2>
+          </h1>
         </EuiModalHeaderTitle>
       </EuiModalHeader>
 

diff --git a/x-pack/plugins/ml/public/embeddables/anomaly_swimlane/anomaly_swimlane_initializer.tsx b/x-pack/plugins/ml/public/embeddables/anomaly_swimlane/anomaly_swimlane_initializer.tsx
@@ -93,10 +93,12 @@ export const AnomalySwimlaneInitializer: FC<AnomalySwimlaneInitializerProps> = (
     <EuiModal initialFocus="[name=panelTitle]" onClose={onCancel}>
       <EuiModalHeader>
         <EuiModalHeaderTitle>
-          <FormattedMessage
-            id="xpack.ml.swimlaneEmbeddable.setupModal.title"
-            defaultMessage="Anomaly swim lane configuration"
-          />
+          <h1>
+            <FormattedMessage
+              id="xpack.ml.swimlaneEmbeddable.setupModal.title"
+              defaultMessage="Anomaly swim lane configuration"
+            />
+          </h1>
         </EuiModalHeaderTitle>
       </EuiModalHeader>