make thresholdRule config optional

elastic · Dec 6, 2023 · b37116e · b37116e
1 parent 8393941
commit b37116e
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 8 deletions.
diff --git a/x-pack/plugins/observability/public/pages/alerts/alerts.test.tsx b/x-pack/plugins/observability/public/pages/alerts/alerts.test.tsx
@@ -58,7 +58,6 @@ jest.spyOn(pluginContext, 'usePluginContext').mockImplementation(() => ({
         uptime: { enabled: false },
         observability: { enabled: false },
       },
-      thresholdRule: { enabled: false },
     },
     aiAssistant: {
       enabled: false,

diff --git a/x-pack/plugins/observability/public/pages/overview/overview.stories.tsx b/x-pack/plugins/observability/public/pages/overview/overview.stories.tsx
@@ -78,7 +78,7 @@ const withCore = makeDecorator({
       },
     } as unknown as Partial<CoreStart>);
 
-    const config = {
+    const config: ConfigSchema = {
       unsafe: {
         alertDetails: {
           logs: { enabled: false },
@@ -87,7 +87,7 @@ const withCore = makeDecorator({
           observability: { enabled: false },
         },
       },
-    } as ConfigSchema;
+    };
 
     return (
       <MemoryRouter>

diff --git a/x-pack/plugins/observability/public/pages/rules/rules.test.tsx b/x-pack/plugins/observability/public/pages/rules/rules.test.tsx
@@ -45,7 +45,6 @@ jest.spyOn(pluginContext, 'usePluginContext').mockImplementation(() => ({
         uptime: { enabled: false },
         observability: { enabled: false },
       },
-      thresholdRule: { enabled: false },
     },
   },
   observabilityRuleTypeRegistry: createObservabilityRuleTypeRegistryMock(),

diff --git a/x-pack/plugins/observability/public/plugin.ts b/x-pack/plugins/observability/public/plugin.ts
@@ -100,7 +100,7 @@ export interface ConfigSchema {
         enabled: boolean;
       };
     };
-    thresholdRule: {
+    thresholdRule?: {
       enabled: boolean;
     };
   };

diff --git a/x-pack/plugins/observability/public/utils/kibana_react.storybook_decorator.tsx b/x-pack/plugins/observability/public/utils/kibana_react.storybook_decorator.tsx
@@ -25,7 +25,7 @@ export function KibanaReactStorybookDecorator(Story: ComponentType) {
   } as unknown as AppMountParameters;
   const observabilityRuleTypeRegistry = createObservabilityRuleTypeRegistryMock();
 
-  const config = {
+  const config: ConfigSchema = {
     unsafe: {
       alertDetails: {
         logs: { enabled: false },
@@ -34,7 +34,7 @@ export function KibanaReactStorybookDecorator(Story: ComponentType) {
         observability: { enabled: false },
       },
     },
-  } as ConfigSchema;
+  };
 
   const mockTheme: CoreTheme = {
     darkMode: false,

diff --git a/x-pack/plugins/observability/public/utils/test_helper.tsx b/x-pack/plugins/observability/public/utils/test_helper.tsx
@@ -38,7 +38,7 @@ const defaultConfig: ConfigSchema = {
       observability: { enabled: false },
     },
   },
-} as ConfigSchema;
+};
 
 const queryClient = new QueryClient({
   defaultOptions: {