TS Panel_error and dashboard_constant (#22141)

* Panel migration to ts

Added the getKibanaVersion to index.d.ts file
Panel error now in ts

* test

* Panel migration to ts

Added the getKibanaVersion to index.d.ts file
Panel error now in ts

* deleted dashboard_constants.js

* removed comment in dashboard_constants

src/core_plugins/kibana/public/dashboard/dashboard_constants.js → src/core_plugins/kibana/public/dashboard/dashboard_constants.ts

@@ -28,6 +28,6 @@ export const DASHBOARD_GRID_HEIGHT = 20;
 export const DEFAULT_PANEL_WIDTH = DASHBOARD_GRID_COLUMN_COUNT / 2;
 export const DEFAULT_PANEL_HEIGHT = 15;
 
-export function createDashboardEditUrl(id) {
+export function createDashboardEditUrl(id: string) {
   return `/dashboard/${id}`;
 }

src/core_plugins/kibana/public/dashboard/panel/panel_error.js → src/core_plugins/kibana/public/dashboard/panel/panel_error.tsx

@@ -18,21 +18,16 @@
  */
 
 import React from 'react';
-import PropTypes from 'prop-types';
 
-export function PanelError({ error }) {
+export interface PanelErrorProps {
+  error: string | React.ReactNode;
+}
+
+export function PanelError({ error }: PanelErrorProps) {
   return (
     <div className="dshPanel__error panel-content">
-      <span aria-hidden="true" className="kuiIcon fa-exclamation-triangle"/>
+      <span aria-hidden="true" className="kuiIcon fa-exclamation-triangle" />
       <span>{error}</span>
     </div>
   );
 }
-
-PanelError.propTypes = {
-  error: PropTypes.oneOfType([
-    PropTypes.string,
-    PropTypes.node
-  ]),
-};
-

src/ui/public/chrome/index.d.ts

@@ -26,6 +26,7 @@ declare class Chrome {
   public dangerouslyGetActiveInjector(): Promise<IInjector>;
   public getBasePath(): string;
   public getXsrfToken(): string;
+  public getKibanaVersion(): string;
 }
 
 declare const chrome: Chrome;