Skip to content

Commit

Permalink
[ML] Functional API tests - bucket span estimation with custom search…
Browse files Browse the repository at this point in the history
….max_buckets (#59665) (#59772)

This PR adds functional API tests for the bucket span estimation endpoint with a transient or persistent `search.max_buckets` setting.
  • Loading branch information
pheyos authored Mar 10, 2020
1 parent b77b127 commit b5d4ca6
Showing 1 changed file with 62 additions and 3 deletions.
65 changes: 62 additions & 3 deletions x-pack/test/api_integration/apis/ml/bucket_span_estimator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ const testDataList = [
// eslint-disable-next-line import/no-default-export
export default ({ getService }: FtrProviderContext) => {
const esArchiver = getService('esArchiver');
const esSupertest = getService('esSupertest');
const supertest = getService('supertest');

describe('bucket span estimator', () => {
Expand All @@ -75,8 +76,66 @@ export default ({ getService }: FtrProviderContext) => {
await esArchiver.unload('ml/ecommerce');
});

for (const testData of testDataList) {
it(`estimates the bucket span ${testData.testTitleSuffix}`, async () => {
describe('with default settings', function() {
for (const testData of testDataList) {
it(`estimates the bucket span ${testData.testTitleSuffix}`, async () => {
const { body } = await supertest
.post('/api/ml/validate/estimate_bucket_span')
.set(COMMON_HEADERS)
.send(testData.requestBody)
.expect(testData.expected.responseCode);

expect(body).to.eql(testData.expected.responseBody);
});
}
});

describe('with transient search.max_buckets setting', function() {
before(async () => {
await esSupertest
.put('/_cluster/settings')
.send({ transient: { 'search.max_buckets': 9000 } })
.expect(200);
});

after(async () => {
await esSupertest
.put('/_cluster/settings')
.send({ transient: { 'search.max_buckets': null } })
.expect(200);
});

const testData = testDataList[0];

it(`estimates the bucket span`, async () => {
const { body } = await supertest
.post('/api/ml/validate/estimate_bucket_span')
.set(COMMON_HEADERS)
.send(testData.requestBody)
.expect(testData.expected.responseCode);

expect(body).to.eql(testData.expected.responseBody);
});
});

describe('with persistent search.max_buckets setting', function() {
before(async () => {
await esSupertest
.put('/_cluster/settings')
.send({ persistent: { 'search.max_buckets': 9000 } })
.expect(200);
});

after(async () => {
await esSupertest
.put('/_cluster/settings')
.send({ persistent: { 'search.max_buckets': null } })
.expect(200);
});

const testData = testDataList[0];

it(`estimates the bucket span`, async () => {
const { body } = await supertest
.post('/api/ml/validate/estimate_bucket_span')
.set(COMMON_HEADERS)
Expand All @@ -85,6 +144,6 @@ export default ({ getService }: FtrProviderContext) => {

expect(body).to.eql(testData.expected.responseBody);
});
}
});
});
};

0 comments on commit b5d4ca6

Please sign in to comment.