Skip to content

Commit

Permalink
fix data-shared-items-container on visualise page (#52370)
Browse files Browse the repository at this point in the history
Addresses #52109 (comment)

Should fix #51309,
Regression was introduced in: #46910
  • Loading branch information
Dosant authored Dec 7, 2019
1 parent 5007bbf commit b66af16
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,6 @@ export class VisualizeEmbeddable extends Embeddable<VisualizeInput, VisualizeOut

div.setAttribute('data-test-subj', 'visualizationLoader');
div.setAttribute('data-shared-item', '');
div.setAttribute('data-shared-item-container', '');
div.setAttribute('data-rendering-count', '0');
div.setAttribute('data-render-complete', 'false');

Expand Down
1 change: 1 addition & 0 deletions src/legacy/ui/public/vis/editors/default/default.html
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

<div
class="visEditor__canvas"
data-shared-items-container
/>

</div>
2 changes: 1 addition & 1 deletion test/functional/page_objects/common_page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ export function CommonPageProvider({ getService, getPageObjects }: FtrProviderCo
}

async getSharedItemContainers() {
const cssSelector = '[data-shared-item-container]';
const cssSelector = '[data-shared-items-container]';
return find.allByCssSelector(cssSelector);
}

Expand Down

0 comments on commit b66af16

Please sign in to comment.