removed isEditable code from dashboard container factory

elastic · Dec 7, 2020 · bfc3de3 · bfc3de3
1 parent 0c81703
commit bfc3de3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/plugins/dashboard/public/application/embeddable/dashboard_container.tsx b/src/plugins/dashboard/public/application/embeddable/dashboard_container.tsx
@@ -78,7 +78,6 @@ export interface DashboardContainerServices {
   overlays: CoreStart['overlays'];
   uiSettings: IUiSettingsClient;
   embeddable: EmbeddableStart;
-  hideWriteControls: boolean;
   uiActions: UiActionsStart;
   http: CoreStart['http'];
 }

diff --git a/src/plugins/dashboard/public/application/embeddable/dashboard_container_factory.tsx b/src/plugins/dashboard/public/application/embeddable/dashboard_container_factory.tsx
@@ -50,8 +50,8 @@ export class DashboardContainerFactoryDefinition
   ) {}
 
   public isEditable = async () => {
-    const { application, hideWriteControls } = await this.getStartServices();
-    return !!application.capabilities.createNew && !hideWriteControls;
+    // Currently unused for dashboards
+    return false;
   };
 
   public readonly getDisplayName = () => {