Account for empty yaml value

elastic · Mar 17, 2020 · c18b8d9 · c18b8d9
1 parent fc6ef12
commit c18b8d9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/x-pack/plugins/ingest_manager/common/services/datasource_to_agent_datasource.test.ts b/x-pack/plugins/ingest_manager/common/services/datasource_to_agent_datasource.test.ts
@@ -39,6 +39,10 @@ describe('Ingest Manager - storedDatasourceToAgentDatasource', () => {
             value:
               '- namespace: mockNamespace\n  #disabledProp: ["test"]\n  anotherProp: test\n- namespace: mockNamespace2\n  #disabledProp: ["test2"]\n  anotherProp: test2',
           },
+          barVar4: {
+            type: 'yaml',
+            value: '',
+          },
         },
       },
     ],

diff --git a/x-pack/plugins/ingest_manager/common/services/datasource_to_agent_datasource.ts b/x-pack/plugins/ingest_manager/common/services/datasource_to_agent_datasource.ts
@@ -28,7 +28,9 @@ export const storedDatasourceToAgentDatasource = (
                 (acc, [configName, { type: configType, value: configValue }]) => {
                   if (configValue !== undefined) {
                     if (configType === 'yaml') {
-                      acc[configName] = safeLoad(configValue);
+                      if (configValue.trim()) {
+                        acc[configName] = safeLoad(configValue);
+                      }
                     } else {
                       acc[configName] = configValue;
                     }