adding real values to messages

x-pack/plugins/ml/common/constants/categorization_job.ts

@@ -0,0 +1,80 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { i18n } from '@kbn/i18n';
+import { VALIDATION_RESULT } from '../types/categories';
+
+export const NUMBER_OF_CATEGORY_EXAMPLES = 5;
+export const CATEGORY_EXAMPLES_SAMPLE_SIZE = 1000;
+export const CATEGORY_EXAMPLES_WARNING_LIMIT = 0.75;
+export const CATEGORY_EXAMPLES_ERROR_LIMIT = 0.02;
+
+export const VALID_TOKEN_COUNT = 3;
+export const MEDIAN_LINE_LENGTH_LIMIT = 400;
+export const NULL_COUNT_PERCENT_LIMIT = 0.75;
+
+export enum CATEGORY_EXAMPLES_VALIDATION_STATUS {
+  VALID = 'valid',
+  PARTIALLY_VALID = 'partially_valid',
+  INVALID = 'invalid',
+}
+
+export const VALIDATION_CHECK_DESCRIPTION = {
+  [VALIDATION_RESULT.NO_EXAMPLES]: i18n.translate(
+    'xpack.ml.models.jobService.categorization.messages.validNoDataFound',
+    {
+      defaultMessage: 'Examples  were successfully loaded.',
+    }
+  ),
+  [VALIDATION_RESULT.FAILED_TO_TOKENIZE]: i18n.translate(
+    'xpack.ml.models.jobService.categorization.messages.validFailureToGetTokens',
+    {
+      defaultMessage: 'The examples loaded were tokenized successfully.',
+    }
+  ),
+  [VALIDATION_RESULT.TOKEN_COUNT]: i18n.translate(
+    'xpack.ml.models.jobService.categorization.messages.validTokenLength',
+    {
+      defaultMessage:
+        'More than {tokenCount} tokens per example were found in over {percentage}% of the examples loaded.',
+      values: {
+        percentage: Math.floor(CATEGORY_EXAMPLES_WARNING_LIMIT * 100),
+        tokenCount: VALID_TOKEN_COUNT,
+      },
+    }
+  ),
+  [VALIDATION_RESULT.MEDIAN_LINE_LENGTH]: i18n.translate(
+    'xpack.ml.models.jobService.categorization.messages.validMedianLineLength',
+    {
+      defaultMessage:
+        'The median line length of the examples loaded was less than {medianCharCount} characters.',
+      values: {
+        medianCharCount: MEDIAN_LINE_LENGTH_LIMIT,
+      },
+    }
+  ),
+  [VALIDATION_RESULT.NULL_VALUES]: i18n.translate(
+    'xpack.ml.models.jobService.categorization.messages.validNullValues',
+    {
+      defaultMessage: 'Less than {percentage}% of the examples loaded were null.',
+      values: {
+        percentage: Math.floor(100 - NULL_COUNT_PERCENT_LIMIT * 100),
+      },
+    }
+  ),
+  [VALIDATION_RESULT.TOO_MANY_TOKENS]: i18n.translate(
+    'xpack.ml.models.jobService.categorization.messages.validTooManyTokens',
+    {
+      defaultMessage: 'Less than 10000 tokens were found in total in the examples loaded.',
+    }
+  ),
+  [VALIDATION_RESULT.INSUFFICIENT_PRIVILEGES]: i18n.translate(
+    'xpack.ml.models.jobService.categorization.messages.validUserPrivileges',
+    {
+      defaultMessage: 'The user has sufficient privileges to perform the checks.',
+    }
+  ),
+};

x-pack/plugins/ml/common/constants/new_job.ts

@@ -25,15 +25,3 @@ export const DEFAULT_RARE_BUCKET_SPAN = '1h';
 export const DEFAULT_QUERY_DELAY = '60s';
 
 export const SHARED_RESULTS_INDEX_NAME = 'shared';
-
-// Categorization
-export const NUMBER_OF_CATEGORY_EXAMPLES = 5;
-export const CATEGORY_EXAMPLES_SAMPLE_SIZE = 1000;
-export const CATEGORY_EXAMPLES_WARNING_LIMIT = 0.75;
-export const CATEGORY_EXAMPLES_ERROR_LIMIT = 0.02;
-
-export enum CATEGORY_EXAMPLES_VALIDATION_STATUS {
-  VALID = 'valid',
-  PARTIALLY_VALID = 'partially_valid',
-  INVALID = 'invalid',
-}

x-pack/plugins/ml/common/types/categories.ts

@@ -4,8 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { i18n } from '@kbn/i18n';
-import { CATEGORY_EXAMPLES_VALIDATION_STATUS } from '../constants/new_job';
+import { CATEGORY_EXAMPLES_VALIDATION_STATUS } from '../constants/categorization_job';
 
 export type CategoryId = number;
 
@@ -54,49 +53,3 @@ export interface FieldExampleCheck {
   valid: CATEGORY_EXAMPLES_VALIDATION_STATUS;
   message: string;
 }
-
-export const VALIDATION_CHECK_DESCRIPTION = {
-  [VALIDATION_RESULT.NO_EXAMPLES]: i18n.translate(
-    'xpack.ml.models.jobService.categorization.messages.validNoDataFound',
-    {
-      defaultMessage: 'Examples  were successfully loaded.',
-    }
-  ),
-  [VALIDATION_RESULT.FAILED_TO_TOKENIZE]: i18n.translate(
-    'xpack.ml.models.jobService.categorization.messages.validFailureToGetTokens',
-    {
-      defaultMessage: 'The examples loaded were tokenized successfully.',
-    }
-  ),
-  [VALIDATION_RESULT.TOKEN_COUNT]: i18n.translate(
-    'xpack.ml.models.jobService.categorization.messages.validTokenLength',
-    {
-      defaultMessage:
-        'More than 3 tokens per example were found in over 75% of the examples loaded.',
-    }
-  ),
-  [VALIDATION_RESULT.MEDIAN_LINE_LENGTH]: i18n.translate(
-    'xpack.ml.models.jobService.categorization.messages.validMedianLineLength',
-    {
-      defaultMessage: 'The median line length of the examples loaded was less than 400 characters.',
-    }
-  ),
-  [VALIDATION_RESULT.NULL_VALUES]: i18n.translate(
-    'xpack.ml.models.jobService.categorization.messages.validNullValues',
-    {
-      defaultMessage: 'Less than 25% of the examples loaded were null.',
-    }
-  ),
-  [VALIDATION_RESULT.TOO_MANY_TOKENS]: i18n.translate(
-    'xpack.ml.models.jobService.categorization.messages.validTooManyTokens',
-    {
-      defaultMessage: 'Less than 10000 tokens were found in total in the examples loaded.',
-    }
-  ),
-  [VALIDATION_RESULT.INSUFFICIENT_PRIVILEGES]: i18n.translate(
-    'xpack.ml.models.jobService.categorization.messages.validUserPrivileges',
-    {
-      defaultMessage: 'The user has sufficient privileges to perform the checks.',
-    }
-  ),
-};

x-pack/plugins/ml/public/application/jobs/new_job/common/job_creator/categorization_job_creator.ts

@@ -16,8 +16,8 @@ import {
   CREATED_BY_LABEL,
   DEFAULT_BUCKET_SPAN,
   DEFAULT_RARE_BUCKET_SPAN,
-  CATEGORY_EXAMPLES_VALIDATION_STATUS,
 } from '../../../../../../common/constants/new_job';
+import { CATEGORY_EXAMPLES_VALIDATION_STATUS } from '../../../../../../common/constants/categorization_job';
 import { ML_JOB_AGGREGATION } from '../../../../../../common/constants/aggregation_types';
 import {
   CategorizationAnalyzer,

x-pack/plugins/ml/public/application/jobs/new_job/common/job_validator/job_validator.ts

@@ -16,7 +16,7 @@ import { JobCreator, JobCreatorType, isCategorizationJobCreator } from '../job_c
 import { populateValidationMessages, checkForExistingJobAndGroupIds } from './util';
 import { ExistingJobsAndGroups } from '../../../../services/job_service';
 import { cardinalityValidator, CardinalityValidatorResult } from './validators';
-import { CATEGORY_EXAMPLES_VALIDATION_STATUS } from '../../../../../../common/constants/new_job';
+import { CATEGORY_EXAMPLES_VALIDATION_STATUS } from '../../../../../../common/constants/categorization_job';
 
 // delay start of validation to allow the user to make changes
 // e.g. if they are typing in a new value, try not to validate

x-pack/plugins/ml/public/application/jobs/new_job/common/results_loader/categorization_examples_loader.ts

@@ -11,7 +11,7 @@ import { ml } from '../../../../services/ml_api_service';
 import {
   NUMBER_OF_CATEGORY_EXAMPLES,
   CATEGORY_EXAMPLES_VALIDATION_STATUS,
-} from '../../../../../../common/constants/new_job';
+} from '../../../../../../common/constants/categorization_job';
 
 export class CategorizationExamplesLoader {
   private _jobCreator: CategorizationJobCreator;

x-pack/plugins/ml/public/application/jobs/new_job/pages/components/pick_fields_step/components/categorization_view/examples_valid_callout.tsx

@@ -21,11 +21,11 @@ import {
   FieldExampleCheck,
 } from '../../../../../../../../../common/types/categories';
 import { EditCategorizationAnalyzerFlyout } from '../../../common/edit_categorization_analyzer_flyout';
-import { CATEGORY_EXAMPLES_VALIDATION_STATUS } from '../../../../../../../../../common/constants/new_job';
 import {
-  VALIDATION_RESULT,
+  CATEGORY_EXAMPLES_VALIDATION_STATUS,
   VALIDATION_CHECK_DESCRIPTION,
-} from '../../../../../../../../../common/types/categories';
+} from '../../../../../../../../../common/constants/categorization_job';
+import { VALIDATION_RESULT } from '../../../../../../../../../common/types/categories';
 
 interface Props {
   validationChecks: FieldExampleCheck[];

x-pack/plugins/ml/public/application/jobs/new_job/pages/components/pick_fields_step/components/categorization_view/metric_selection.tsx

@@ -18,7 +18,7 @@ import {
   CategoryFieldExample,
   FieldExampleCheck,
 } from '../../../../../../../../../common/types/categories';
-import { CATEGORY_EXAMPLES_VALIDATION_STATUS } from '../../../../../../../../../common/constants/new_job';
+import { CATEGORY_EXAMPLES_VALIDATION_STATUS } from '../../../../../../../../../common/constants/categorization_job';
 import { LoadingWrapper } from '../../../charts/loading_wrapper';
 
 interface Props {

x-pack/plugins/ml/public/application/jobs/new_job/pages/components/pick_fields_step/components/categorization_view/top_categories.tsx

@@ -11,7 +11,7 @@ import { JobCreatorContext } from '../../../job_creator_context';
 import { CategorizationJobCreator } from '../../../../../common/job_creator';
 import { Results } from '../../../../../common/results_loader';
 import { ml } from '../../../../../../../services/ml_api_service';
-import { NUMBER_OF_CATEGORY_EXAMPLES } from '../../../../../../../../../common/constants/new_job';
+import { NUMBER_OF_CATEGORY_EXAMPLES } from '../../../../../../../../../common/constants/categorization_job';
 
 export const TopCategories: FC = () => {
   const { jobCreator: jc, resultsLoader } = useContext(JobCreatorContext);

x-pack/plugins/ml/public/application/services/ml_api_service/jobs.ts

@@ -17,7 +17,7 @@ import {
   CategoryFieldExample,
   FieldExampleCheck,
 } from '../../../../common/types/categories';
-import { CATEGORY_EXAMPLES_VALIDATION_STATUS } from '../../../../common/constants/new_job';
+import { CATEGORY_EXAMPLES_VALIDATION_STATUS } from '../../../../common/constants/categorization_job';
 import { Category } from '../../../../common/types/categories';
 
 export const jobs = {

x-pack/plugins/ml/server/models/job_service/new_job/categorization/examples.ts

@@ -6,7 +6,7 @@
 
 import { chunk } from 'lodash';
 import { SearchResponse } from 'elasticsearch';
-import { CATEGORY_EXAMPLES_SAMPLE_SIZE } from '../../../../../common/constants/new_job';
+import { CATEGORY_EXAMPLES_SAMPLE_SIZE } from '../../../../../common/constants/categorization_job';
 import {
   Token,
   CategorizationAnalyzer,

x-pack/plugins/ml/server/models/job_service/new_job/categorization/validation_results.ts

@@ -6,21 +6,20 @@
 
 import { i18n } from '@kbn/i18n';
 import {
+  VALID_TOKEN_COUNT,
+  MEDIAN_LINE_LENGTH_LIMIT,
+  NULL_COUNT_PERCENT_LIMIT,
   CATEGORY_EXAMPLES_VALIDATION_STATUS,
   CATEGORY_EXAMPLES_ERROR_LIMIT,
   CATEGORY_EXAMPLES_WARNING_LIMIT,
-} from '../../../../../common/constants/new_job';
+} from '../../../../../common/constants/categorization_job';
 import {
   FieldExampleCheck,
   CategoryFieldExample,
   VALIDATION_RESULT,
 } from '../../../../../common/types/categories';
 import { getMedianStringLength } from '../../../../../common/util/string_utils';
 
-const VALID_TOKEN_COUNT = 3;
-const MEDIAN_LINE_LENGTH_LIMIT = 400;
-const NULL_COUNT_PERCENT_LIMIT = 0.75;
-
 export class ValidationResults {
   private _results: FieldExampleCheck[] = [];