Skip to content

Commit

Permalink
Review feedback: improve test by splitting variable over chunks
Browse files Browse the repository at this point in the history
  • Loading branch information
rudolf committed Mar 12, 2021
1 parent 063ac5d commit ce14023
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions packages/kbn-es-archiver/src/lib/archives/parse.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ describe('esArchiver createParseArchiveStreams', () => {
it('replaces $KIBANA_PACKAGE_VERSION with the current kibana version', async () => {
const output = await createPromiseFromStreams([
createListStream([
Buffer.from('{'),
Buffer.from('"$KIBANA_PACKAGE_VERSION": "enabled"}'),
Buffer.from('{"$KIBANA'),
Buffer.from('_PACKAGE_VERSION": "enabled"}'),
]),
...createParseArchiveStreams({ gzip: false }),
]);
Expand Down Expand Up @@ -158,8 +158,8 @@ describe('esArchiver createParseArchiveStreams', () => {
it('replaces $KIBANA_PACKAGE_VERSION with the current kibana version', async () => {
const output = await createPromiseFromStreams([
createListStream([
Buffer.from('{'),
Buffer.from('"$KIBANA_PACKAGE_VERSION": "enabled"}'),
Buffer.from('{"$KIBANA_PACKAGE'),
Buffer.from('_VERSION": "enabled"}'),
]),
createGzip(),
...createParseArchiveStreams({ gzip: true }),
Expand Down

0 comments on commit ce14023

Please sign in to comment.