Fixed eslint issues and added labels for buttons

elastic · Feb 15, 2021 · d2f49db · d2f49db
1 parent c806392
commit d2f49db
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 25 deletions.
diff --git a/...nagement/public/application/sections/edit_policy/components/phase_footer/phase_footer.tsx b/...nagement/public/application/sections/edit_policy/components/phase_footer/phase_footer.tsx
@@ -17,6 +17,20 @@ import { usePhaseTimings } from '../../form';
 
 import { InfinityIconSvg } from '../infinity_icon/infinity_icon.svg';
 
+const deleteDataLabel = i18n.translate(
+  'xpack.indexLifecycleMgmt.editPolicy.phaseTiming.beforeDeleteDescription',
+  {
+    defaultMessage: 'Delete data after this phase',
+  }
+);
+
+const keepDataLabel = i18n.translate(
+  'xpack.indexLifecycleMgmt.editPolicy.phaseTiming.foreverTimingDescription',
+  {
+    defaultMessage: 'Keep data in this phase forever',
+  }
+);
+
 interface Props {
   phase: PhasesExceptDelete;
 }
@@ -31,38 +45,19 @@ export const PhaseFooter: FunctionComponent<Props> = ({ phase }) => {
   if (!phaseConfiguration.isFinalDataPhase) {
     return null;
   }
-
-  const phaseDescription = isDeletePhaseEnabled
-    ? i18n.translate('xpack.indexLifecycleMgmt.editPolicy.phaseTiming.beforeDeleteDescription', {
-        defaultMessage: 'Delete data after this phase',
-      })
-    : i18n.translate('xpack.indexLifecycleMgmt.editPolicy.phaseTiming.foreverTimingDescription', {
-        defaultMessage: 'Keep data in this phase forever',
-      });
-
   const selectedButton = isDeletePhaseEnabled
     ? 'ilmEnableDeletePhaseButton'
     : 'ilmDisableDeletePhaseButton';
 
   const buttons = [
     {
       id: `ilmDisableDeletePhaseButton`,
-      label: i18n.translate(
-        'xpack.indexLifecycleMgmt.editPolicy.deletePhase.disablePhaseButtonLabel',
-        {
-          defaultMessage: 'Keep data in this phase forever',
-        }
-      ),
+      label: keepDataLabel,
       iconType: InfinityIconSvg,
     },
     {
       id: `ilmEnableDeletePhaseButton`,
-      label: i18n.translate(
-        'xpack.indexLifecycleMgmt.editPolicy.deletePhase.enablePhaseButtonLabel',
-        {
-          defaultMessage: 'Delete data after this phase',
-        }
-      ),
+      label: deleteDataLabel,
       iconType: 'trash',
       'data-test-subj': 'enableDeletePhaseButton',
     },
@@ -72,7 +67,7 @@ export const PhaseFooter: FunctionComponent<Props> = ({ phase }) => {
     <EuiFlexGroup alignItems="center" gutterSize="s" wrap>
       <EuiFlexItem grow={false}>
         <EuiText size="s" color="subdued">
-          {phaseDescription}
+          {isDeletePhaseEnabled ? deleteDataLabel : keepDataLabel}
         </EuiText>
       </EuiFlexItem>
       <EuiFlexItem grow={false}>

diff --git a/.../plugins/index_lifecycle_management/public/application/sections/edit_policy/i18n_texts.ts b/.../plugins/index_lifecycle_management/public/application/sections/edit_policy/i18n_texts.ts
@@ -203,13 +203,12 @@ export const i18nTexts = {
       }),
       cold: i18n.translate('xpack.indexLifecycleMgmt.editPolicy.coldPhase.coldPhaseDescription', {
         defaultMessage:
-          'Move data to the cold tier, which is optimized for cost savings over search performance. Data is normally read-only in the cold phase.,
+          'Move data to the cold tier, which is optimized for cost savings over search performance. Data is normally read-only in the cold phase.',
       }),
       delete: i18n.translate(
         'xpack.indexLifecycleMgmt.editPolicy.deletePhase.deletePhaseDescription',
         {
-          defaultMessage:
-            'Delete data you no longer need.',
+          defaultMessage: 'Delete data you no longer need.',
         }
       ),
     },