[ML] Fix jest tests. Use replace() with global regex instead of repla…

…ceAll().
elastic · Feb 19, 2021 · dd0f4c0 · dd0f4c0
1 parent 4d63196
commit dd0f4c0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 19 deletions.
diff --git a/...ublic/application/components/scatterplot_matrix/scatterplot_matrix_vega_lite_spec.test.ts b/...ublic/application/components/scatterplot_matrix/scatterplot_matrix_vega_lite_spec.test.ts
@@ -67,10 +67,6 @@ describe('getScatterplotMatrixVegaLiteSpec()', () => {
       column: ['x', 'y'],
       row: ['y', 'x'],
     });
-    expect(vegaLiteSpec.spec.transform).toEqual([
-      { as: 'x', calculate: "datum['x']" },
-      { as: 'y', calculate: "datum['y']" },
-    ]);
     expect(vegaLiteSpec.spec.data.values).toEqual(data);
     expect(vegaLiteSpec.spec.mark).toEqual({
       opacity: 0.75,
@@ -96,14 +92,6 @@ describe('getScatterplotMatrixVegaLiteSpec()', () => {
       column: ['x', 'y'],
       row: ['y', 'x'],
     });
-    expect(vegaLiteSpec.spec.transform).toEqual([
-      { as: 'x', calculate: "datum['x']" },
-      { as: 'y', calculate: "datum['y']" },
-      {
-        as: 'outlier_score',
-        calculate: "datum['ml.outlier_score']",
-      },
-    ]);
     expect(vegaLiteSpec.spec.data.values).toEqual(data);
     expect(vegaLiteSpec.spec.mark).toEqual({
       opacity: 0.75,
@@ -112,7 +100,8 @@ describe('getScatterplotMatrixVegaLiteSpec()', () => {
     });
     expect(vegaLiteSpec.spec.encoding.color).toEqual({
       condition: {
-        test: "(datum['outlier_score'] >= mlOutlierScoreThreshold.cutoff)",
+        // Note the alternative UTF-8 dot character
+        test: "(datum['ml․outlier_score'] >= mlOutlierScoreThreshold.cutoff)",
         value: COLOR_OUTLIER,
       },
       value: euiThemeLight.euiColorMediumShade,
@@ -121,7 +110,8 @@ describe('getScatterplotMatrixVegaLiteSpec()', () => {
       { field: 'x', type: 'quantitative' },
       { field: 'y', type: 'quantitative' },
       {
-        field: 'outlier_score',
+        // Note the alternative UTF-8 dot character
+        field: 'ml․outlier_score',
         format: '.3f',
         type: 'quantitative',
       },
@@ -147,10 +137,6 @@ describe('getScatterplotMatrixVegaLiteSpec()', () => {
       column: ['x', 'y'],
       row: ['y', 'x'],
     });
-    expect(vegaLiteSpec.spec.transform).toEqual([
-      { as: 'x', calculate: "datum['x']" },
-      { as: 'y', calculate: "datum['y']" },
-    ]);
     expect(vegaLiteSpec.spec.data.values).toEqual(data);
     expect(vegaLiteSpec.spec.mark).toEqual({
       opacity: 0.75,

diff --git a/.../ml/public/application/components/scatterplot_matrix/scatterplot_matrix_vega_lite_spec.ts b/.../ml/public/application/components/scatterplot_matrix/scatterplot_matrix_vega_lite_spec.ts
@@ -63,7 +63,7 @@ export const getColorSpec = (
 // since VEGA treats dots in field names as nested values and escaping
 // in columns/rows for repeated charts isn't working as expected.
 function getEscapedVegaFieldName(fieldName: string) {
-  return fieldName.replaceAll('.', '․');
+  return fieldName.replace(/\./g, '․');
 }
 
 // Replace dots for all keys of all data items with an alternative UTF-8 character