fixing unit test

elastic · Nov 13, 2019 · e88e4a9 · e88e4a9
1 parent 7d92d0a
commit e88e4a9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/x-pack/legacy/plugins/apm/public/components/shared/MetadataTable/Section.tsx b/x-pack/legacy/plugins/apm/public/components/shared/MetadataTable/Section.tsx
@@ -5,17 +5,18 @@
  */
 
 import React from 'react';
+import { isEmpty } from 'lodash';
 import { i18n } from '@kbn/i18n';
 import { EuiText } from '@elastic/eui';
 import { KeyValueTable } from '../KeyValueTable';
 import { KeyValuePair } from '../../../utils/flattenObject';
 
 interface Props {
-  keyValuePairs?: KeyValuePair[];
+  keyValuePairs: KeyValuePair[];
 }
 
 export function Section({ keyValuePairs }: Props) {
-  if (keyValuePairs && keyValuePairs.length > 0) {
+  if (!isEmpty(keyValuePairs)) {
     return <KeyValueTable keyValuePairs={keyValuePairs} />;
   }
   return (

diff --git a/x-pack/legacy/plugins/apm/public/components/shared/MetadataTable/__test__/Section.test.tsx b/x-pack/legacy/plugins/apm/public/components/shared/MetadataTable/__test__/Section.test.tsx
@@ -11,9 +11,7 @@ import { expectTextsInDocument } from '../../../../utils/testHelpers';
 
 describe('Section', () => {
   it('shows "empty state message" if no data is available', () => {
-    const undefinedPropertyComponent = render(<Section />);
-    expectTextsInDocument(undefinedPropertyComponent, ['No data available']);
-    const emptyPropertyComponent = render(<Section keyValuePairs={[]} />);
-    expectTextsInDocument(emptyPropertyComponent, ['No data available']);
+    const component = render(<Section keyValuePairs={[]} />);
+    expectTextsInDocument(component, ['No data available']);
   });
 });