Skip to content

Commit

Permalink
remove TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
oatkiller committed Mar 4, 2020
1 parent 2f73261 commit eac4bff
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions x-pack/plugins/endpoint/common/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -502,11 +502,11 @@ type KbnConfigSchemaNonOptionalProps<Props extends kbnConfigSchemaTypes.Props> =
/**
* Query params to pass to the alert API when fetching new data.
*/
// TODO rename to Input....
// the type you use when calling the api.
export type AlertingIndexGetQueryInput = KbnConfigSchemaInputTypeOf<
typeof alertingIndexGetQuerySchema
>;

// The type resulting from validating input. used in the handler
/**
* Result of the validated query params when handling alert index requests.
*/
export type AlertingIndexGetQueryResult = TypeOf<typeof alertingIndexGetQuerySchema>;
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export function cloneHttpFetchQuery(query: Immutable<HttpFetchQuery>): HttpFetch
if (Array.isArray(value)) {
clone[key] = [...value];
} else {
// Array.isArray is not removing ImmutableArray from the union. TODO
// Array.isArray is not removing ImmutableArray from the union.
clone[key] = value as string | number | boolean;
}
}
Expand Down

0 comments on commit eac4bff

Please sign in to comment.