[uiApp] remove unused templateName config option

elastic · Mar 30, 2018 · ec5e41c · ec5e41c
1 parent 3a30d0b
commit ec5e41c
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 16 deletions.
diff --git a/src/ui/ui_apps/__tests__/ui_app.js b/src/ui/ui_apps/__tests__/ui_app.js
@@ -18,7 +18,6 @@ function createStubUiAppSpec(extraParams) {
     linkToLastSubUrl: true,
     hidden: false,
     listed: false,
-    templateName: 'ui_app_test',
     uses: [
       'visTypes',
       'chromeNavControls',
@@ -73,10 +72,6 @@ describe('ui apps / UiApp', () => {
         expect(app.getPluginId()).to.be(undefined);
       });
 
-      it('has a default template name of ui_app', () => {
-        expect(app.getTemplateName()).to.be('ui_app');
-      });
-
       it('is not hidden', () => {
         expect(app.isHidden()).to.be(false);
       });
@@ -126,10 +121,6 @@ describe('ui apps / UiApp', () => {
         expect(app.getPluginId()).to.be(undefined);
       });
 
-      it('uses the specs template', () => {
-        expect(app.getTemplateName()).to.be(spec.templateName);
-      });
-
       it('is not hidden', () => {
         expect(app.isHidden()).to.be(false);
       });

diff --git a/src/ui/ui_apps/ui_app.js b/src/ui/ui_apps/ui_app.js
@@ -13,7 +13,6 @@ export class UiApp {
       hidden,
       linkToLastSubUrl,
       listed,
-      templateName = 'ui_app',
       injectVars,
       url = `/app/${id}`,
       uses = []
@@ -32,7 +31,6 @@ export class UiApp {
     this._linkToLastSubUrl = linkToLastSubUrl;
     this._hidden = hidden;
     this._listed = listed;
-    this._templateName = templateName;
     this._url = url;
     this._injectedVarsProvider = injectVars;
     this._pluginId = pluginId;
@@ -79,10 +77,6 @@ export class UiApp {
     return plugin ? plugin.id : undefined;
   }
 
-  getTemplateName() {
-    return this._templateName;
-  }
-
   isHidden() {
     return !!this._hidden;
   }

diff --git a/src/ui/ui_render/ui_render_mixin.js b/src/ui/ui_render/ui_render_mixin.js
@@ -120,7 +120,7 @@ export function uiRenderMixin(kbnServer, server, config) {
       const request = reply.request;
       const translations = await request.getUiTranslations();
 
-      return reply.view(app.getTemplateName(), {
+      return reply.view('ui_app', {
         app,
         kibanaPayload: await getKibanaPayload({
           app,