Skip to content

Commit

Permalink
Address design issues in Discover/Graph (#101584)
Browse files Browse the repository at this point in the history
* Remove Discover panel shadow

* Fix graph issues
  • Loading branch information
Tim Roes authored Jun 9, 2021
1 parent fe6112c commit ee0efab
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,7 @@ export function DiscoverLayout({
verticalPosition={contentCentered ? 'center' : undefined}
horizontalPosition={contentCentered ? 'center' : undefined}
paddingSize="none"
hasShadow={false}
className={classNames('dscPageContent', {
'dscPageContent--centered': contentCentered,
})}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@
initial-filter="initialFilter"
initialPageSize="initialPageSize"
core-start="coreStart"
class="kbnAppWrapper"
></graph-listing>
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ function GuidancePanelComponent(props: GuidancePanelProps) {

const kibana = useKibana<IDataPluginServices>();
const { services, overlays } = kibana;
const { savedObjects, uiSettings, chrome, application } = services;
if (!overlays || !chrome || !application) return null;
const { savedObjects, uiSettings, application } = services;
if (!overlays || !application) return null;

const onOpenDatasourcePicker = () => {
openSourceModal({ overlays, savedObjects, uiSettings }, onIndexPatternSelected);
Expand Down Expand Up @@ -149,8 +149,9 @@ function GuidancePanelComponent(props: GuidancePanelProps) {
);

if (noIndexPatterns) {
const managementUrl = chrome.navLinks.get('kibana:stack_management')!.url;
const indexPatternUrl = `${managementUrl}/kibana/indexPatterns`;
const indexPatternUrl = application.getUrlForApp('management', {
path: '/kibana/indexPatterns',
});
const sampleDataUrl = `${application.getUrlForApp('home')}#/tutorial_directory/sampleData`;
content = (
<EuiPanel paddingSize="none">
Expand Down

0 comments on commit ee0efab

Please sign in to comment.