Addressing PR comments

elastic · Jan 27, 2020 · f34f9a6 · f34f9a6
1 parent 1014777
commit f34f9a6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/x-pack/plugins/features/server/routes/index.ts b/x-pack/plugins/features/server/routes/index.ts
@@ -23,15 +23,17 @@ export function defineRoutes({ router, featureRegistry, getLegacyAPI }: RouteDef
     {
       path: '/api/features',
       options: { tags: ['access:features'] },
-      validate: { query: schema.object({ ignoreValidLicenses: schema.maybe(schema.boolean()) }) },
+      validate: {
+        query: schema.object({ ignoreValidLicenses: schema.boolean({ defaultValue: false }) }),
+      },
     },
     (context, request, response) => {
       const allFeatures = featureRegistry.getAll();
 
       return response.ok({
         body: allFeatures.filter(
           feature =>
-            request.query.ignoreValidLicenses === true ||
+            request.query.ignoreValidLicenses ||
             !feature.validLicenses ||
             !feature.validLicenses.length ||
             getLegacyAPI().xpackInfo.license.isOneOf(feature.validLicenses)

diff --git a/x-pack/test/ui_capabilities/common/services/features.ts b/x-pack/test/ui_capabilities/common/services/features.ts
@@ -25,7 +25,7 @@ export class FeaturesService {
   public async get({ ignoreValidLicenses } = { ignoreValidLicenses: false }): Promise<Features> {
     this.log.debug('requesting /api/features to get the features');
     const response = await this.axios.get(
-      `/api/features${ignoreValidLicenses ? '?ignoreValidLicenses=true' : ''}`
+      `/api/features?ignoreValidLicenses=${ignoreValidLicenses}`
     );
 
     if (response.status !== 200) {