[ML] fix overall stats fetch with a saved search

elastic · Feb 11, 2020 · fb4c72a · fb4c72a
1 parent 62e3189
commit fb4c72a
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/x-pack/legacy/plugins/ml/public/application/datavisualizer/index_based/page.tsx b/x-pack/legacy/plugins/ml/public/application/datavisualizer/index_based/page.tsx
@@ -119,9 +119,6 @@ export const Page: FC = () => {
   }, [globalState?.refreshInterval?.pause, globalState?.refreshInterval?.value]);
 
   const [lastRefresh, setLastRefresh] = useState(0);
-  useEffect(() => {
-    loadOverallStats();
-  }, [lastRefresh]);
 
   useEffect(() => {
     if (currentIndexPattern.timeFieldName !== undefined) {
@@ -227,11 +224,17 @@ export const Page: FC = () => {
       setSearchString(qryString);
       setSearchQueryLanguage(queryLanguage);
     }
-  }, []);
+  }, [currentSavedSearch]);
 
   useEffect(() => {
+    if (!!currentSavedSearch && searchQuery === defaultSearchQuery) {
+      // There is a saved search presented, but the search query has not been
+      // extracted yet.
+      return;
+    }
+
     loadOverallStats();
-  }, [searchQuery, samplerShardSize]);
+  }, [searchQuery, currentSavedSearch, samplerShardSize, lastRefresh]);
 
   useEffect(() => {
     createMetricCards();