Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Allow Package ID in Create Package Policy requests #100897

Closed
kpollich opened this issue May 28, 2021 · 1 comment · Fixed by #100908
Closed

[Fleet] Allow Package ID in Create Package Policy requests #100897

kpollich opened this issue May 28, 2021 · 1 comment · Fixed by #100908
Assignees
@kpollich
Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@kpollich
Copy link
Member

See #99866 (comment)

We expose the package ID at the /api/fleet/epm/packages?experimental=true endpoint, e.g.

Screenshot

Screen Shot 2021-05-28 at 10 19 58 AM

For E2E tests (see linked comment) that use this payload and include the id, and error is throwing upon package policy creation:

{"statusCode":400,"error":"Bad Request","message":"[request body.package.id]: definition for this key is missing"}

Our schema definition for this policy creation request forbids id in the request body. This should be changed to allow for the id field's presence.
@kpollich kpollich added bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team labels May 28, 2021
@kpollich kpollich self-assigned this May 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kpollich kpollich mentioned this issue May 28, 2021
Merged
kpollich added a commit to kpollich/kibana that referenced this issue May 28, 2021
@kpollich
Include ID field in packages on get/create
ee36bb6 
Add `id` field for packages in info/create requests

Closes elastic#100897
@kpollich kpollich mentioned this issue May 28, 2021
Merged
kpollich added a commit to kpollich/kibana that referenced this issue May 28, 2021
@kpollich
Allow for ID in create package policy request
9fb470f 
E2E tests are failing because they include the ID field returned by the
package list endpoint. This just updates our request schema to accept an
ID, though we don't persist or deal with the ID anywhere.

Closes elastic#100897
@mdelapenya mdelapenya mentioned this issue May 29, 2021
Merged
9 tasks
kpollich added a commit that referenced this issue Jun 1, 2021
@kpollich @kibanamachine
Allow for ID in create package policy request (#100908)
151f5fd 
E2E tests are failing because they include the ID field returned by the
package list endpoint. This just updates our request schema to accept an
ID, though we don't persist or deal with the ID anywhere.

Closes #100897

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this issue Jun 1, 2021
@kpollich @kibanamachine
Allow for ID in create package policy request (elastic#100908)
0383b87 
E2E tests are failing because they include the ID field returned by the
package list endpoint. This just updates our request schema to accept an
ID, though we don't persist or deal with the ID anywhere.

Closes elastic#100897

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit that referenced this issue Jun 1, 2021
@kibanamachine @kpollich
Allow for ID in create package policy request (#100908) (#101053)
8a205e3 
E2E tests are failing because they include the ID field returned by the
package list endpoint. This just updates our request schema to accept an
ID, though we don't persist or deal with the ID anywhere.

Closes #100897

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpollich kpollich

Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Include ID field in packages on get/create kpollich/kibana
2 participants
@kpollich @elasticmachine