Don't have the '*' in the search bar by default

[trevan]

Without the '*' in the search bar, the bar will show the placeholder text of "Search...". That makes it more discovererable. I've had several users can't figure out where to type in their search query because of this.

In addition, I've also had a few users type in their search without removing the asterisk. So instead of an easy query of "snow", they are running a regex query of "*snow".

[Bargs]

Hmmm I dunno. It would speed up the initial Discover page load and allow users to see the help text that's displayed when no results are found. But it might be quite common to want to see your most recent documents, which Discover will show you by default. What do you think @tbragin @lukasolson @weltenwort ?

#7238 would help mitigate this issue, but it is worth considering whether we should change the "default default" so to speak.

[trevan]

A blank search bar in Kibana now acts the same as a ''. So why not just leave it that way? When you load discover/dashboard/visualization, you get the "" behavior but it just doesn't show a '*' in the search bar.

I think I even found the place that needs to be changed in the parseQuery directive. I'll have a pull request here shortly to hide the '*'.

[tbragin]

@Bargs I would prefer to start with providing a way to make it configurable via #7238, and then we can see if everyone does it -- then we can change the default. What do you think?

[tbragin]

Though now that I look at it, there doesn't appear to be a way to save a search that does not have a *, so maybe that's not a good solution. I suppose that is what this comment refers to #10272 (comment)

@trevan Do you want the initial load of Discover to still return the results even though the search bar has no "*"? Or to not perform any query at all, and show some sort of help text? I thought it was the former from reading your original ticket, but @Bargs reaction seems to imply the latter.

[trevan]

I want the former. A blank search bar is already equivalent to an asterisk. So instead of showing the asterisk, just use blank.

[Bargs]

@trevan @tbragin apologies, I misunderstood. I know there have been requests to get rid of the initial search completely, so that's where my mind jumped immediately.

Getting rid of the asterisk seems harmless to me. @trevan if you'd like to put up a PR I'd be happy to review.

[trevan]

@Bargs, I just created the pull request.