-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] double clicking to delete shape produces failure to delete error #117369
Comments
Pinging @elastic/kibana-gis (Team:Geo) |
There is more to this issue than just the original description. Adding and deleting features is an asynchronous task takes an unknown amount of time. There needs to be user feedback that something is happening while features are being added and deleted and during this time. Proper user feedback will prevent users from double clicking and so on because those action will be disabled will add/delete action is taking place. Redux action addNewFeatureToIndex and deleteFeatureFromIndex need to set draw_mode to "insert" or "delete" before performing their async request and then return draw_mode to "simple_select" after the async task has finished. Finally DrawControl needs to display a "wait" icon while the draw_mode is "insert" or "delete". |
* #117369 - Fixed double click issue when deleting a shape * #117369 - updated deleting shape method; redux changes; * #117369 - waiting state for adding shapes feature * #1173669 - refactoring; removed unused functions * 117369 - refactoring * 117369 - Updates for onDraw methods, now the selected shape is not reset * 117369 - made addNewFeatureToIndex to be called once * 117369 - refactoring * 117369 - refactoring and clean up * 117369 - removed then method from actions * 117369 - refactoring * 1177369 - refactoring * 117369 - refactoring; Added new state in redux * 117369 - refactoring * 117369 - renaming layerId to featureId Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* elastic#117369 - Fixed double click issue when deleting a shape * elastic#117369 - updated deleting shape method; redux changes; * elastic#117369 - waiting state for adding shapes feature * #1173669 - refactoring; removed unused functions * 117369 - refactoring * 117369 - Updates for onDraw methods, now the selected shape is not reset * 117369 - made addNewFeatureToIndex to be called once * 117369 - refactoring * 117369 - refactoring and clean up * 117369 - removed then method from actions * 117369 - refactoring * 1177369 - refactoring * 117369 - refactoring; Added new state in redux * 117369 - refactoring * 117369 - renaming layerId to featureId Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* elastic#117369 - Fixed double click issue when deleting a shape * elastic#117369 - updated deleting shape method; redux changes; * elastic#117369 - waiting state for adding shapes feature * #1173669 - refactoring; removed unused functions * 117369 - refactoring * 117369 - Updates for onDraw methods, now the selected shape is not reset * 117369 - made addNewFeatureToIndex to be called once * 117369 - refactoring * 117369 - refactoring and clean up * 117369 - removed then method from actions * 117369 - refactoring * 1177369 - refactoring * 117369 - refactoring; Added new state in redux * 117369 - refactoring * 117369 - renaming layerId to featureId Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
When removing a shape, double clicking can lead to two delete requests for the same shape which results in an error.
Untitled.mov
The text was updated successfully, but these errors were encountered: