Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] double clicking to delete shape produces failure to delete error #117369

Closed
mattkime opened this issue Nov 3, 2021 · 2 comments · Fixed by #124661
Closed

[Maps] double clicking to delete shape produces failure to delete error #117369

mattkime opened this issue Nov 3, 2021 · 2 comments · Fixed by #124661
Assignees
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. v8.2.0

Comments

@mattkime
Copy link
Contributor

mattkime commented Nov 3, 2021

When removing a shape, double clicking can lead to two delete requests for the same shape which results in an error.

Untitled.mov
@mattkime mattkime added the [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Nov 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck thomasneirynck added bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Nov 18, 2021
@thomasneirynck thomasneirynck changed the title [maps] double clicking to delete shape produces failure to delete error [Maps] double clicking to delete shape produces failure to delete error Nov 18, 2021
@nreese nreese added the v8.2.0 label Jan 30, 2022
@nreese
Copy link
Contributor

nreese commented Jan 30, 2022

There is more to this issue than just the original description. Adding and deleting features is an asynchronous task takes an unknown amount of time. There needs to be user feedback that something is happening while features are being added and deleted and during this time. Proper user feedback will prevent users from double clicking and so on because those action will be disabled will add/delete action is taking place.

Redux action addNewFeatureToIndex and deleteFeatureFromIndex need to set draw_mode to "insert" or "delete" before performing their async request and then return draw_mode to "simple_select" after the async task has finished.

Finally DrawControl needs to display a "wait" icon while the draw_mode is "insert" or "delete".

maksimkovalev added a commit to maksimkovalev/kibana that referenced this issue Feb 4, 2022
maksimkovalev added a commit to maksimkovalev/kibana that referenced this issue Feb 8, 2022
maksimkovalev added a commit to maksimkovalev/kibana that referenced this issue Feb 9, 2022
nreese pushed a commit that referenced this issue Mar 7, 2022
* #117369 - Fixed double click issue when deleting a shape

* #117369 - updated deleting shape method; redux changes;

* #117369 - waiting state for adding shapes feature

* #1173669 - refactoring; removed unused functions

* 117369 - refactoring

* 117369 - Updates for onDraw methods, now the selected shape is not reset

* 117369 - made addNewFeatureToIndex to be called once

* 117369 - refactoring

* 117369 - refactoring and clean up

* 117369 - removed then method from actions

* 117369 - refactoring

* 1177369 - refactoring

* 117369 - refactoring; Added new state in redux

* 117369 - refactoring

* 117369 - renaming layerId to featureId

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this issue Mar 8, 2022
* elastic#117369 - Fixed double click issue when deleting a shape

* elastic#117369 - updated deleting shape method; redux changes;

* elastic#117369 - waiting state for adding shapes feature

* #1173669 - refactoring; removed unused functions

* 117369 - refactoring

* 117369 - Updates for onDraw methods, now the selected shape is not reset

* 117369 - made addNewFeatureToIndex to be called once

* 117369 - refactoring

* 117369 - refactoring and clean up

* 117369 - removed then method from actions

* 117369 - refactoring

* 1177369 - refactoring

* 117369 - refactoring; Added new state in redux

* 117369 - refactoring

* 117369 - renaming layerId to featureId

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this issue Mar 8, 2022
* elastic#117369 - Fixed double click issue when deleting a shape

* elastic#117369 - updated deleting shape method; redux changes;

* elastic#117369 - waiting state for adding shapes feature

* #1173669 - refactoring; removed unused functions

* 117369 - refactoring

* 117369 - Updates for onDraw methods, now the selected shape is not reset

* 117369 - made addNewFeatureToIndex to be called once

* 117369 - refactoring

* 117369 - refactoring and clean up

* 117369 - removed then method from actions

* 117369 - refactoring

* 1177369 - refactoring

* 117369 - refactoring; Added new state in redux

* 117369 - refactoring

* 117369 - renaming layerId to featureId

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. v8.2.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants