Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra UI] Plugin registrations pull in UI components too eagerly #122941

Closed
weltenwort opened this issue Jan 13, 2022 · 1 comment · Fixed by #123285
Closed

[Infra UI] Plugin registrations pull in UI components too eagerly #122941

weltenwort opened this issue Jan 13, 2022 · 1 comment · Fixed by #123285
Assignees
@weltenwort
Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature performance Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@weltenwort
Copy link
Member

weltenwort commented Jan 13, 2022 •
edited
Loading

📓 Summary

The infra plugin's registration imports too many chunks eagerly.

Kibana version: master as of c9dcd93

👣 Steps to reproduce

  1. Navigate to Kibana's login screen.
  2. Observe that many infra.chunk.N.js bundles are loaded.

✔️ Acceptance criteria

  • Only the initial infra.plugin.js bundle is loaded before navigating to the Logs or Metrics app (in particular not on the login screen).

💡 Implementation hints

This has happened in the past when importing all related UI components for rule registration without wrapping the rule parameterization components in a React.lazy wrapper (see #117187 for a monitoring plugin example). For the infra plugin this was working fine until recently. Maybe a recent change in the plugin initialization caused this for the infra plugin (e.g. #119557).
@weltenwort weltenwort added bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jan 13, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@weltenwort weltenwort self-assigned this Jan 18, 2022
This was referenced Jan 18, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weltenwort weltenwort

Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature performance Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Infra UI] Avoid eager async imports in metric alert registrations weltenwort/kibana
3 participants
@weltenwort @lizozom @elasticmachine