Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] Fail integration tests when async bundles are loaded too eagerly #123630

Closed
weltenwort opened this issue Jan 24, 2022 · 4 comments
Closed
Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature info-needed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@weltenwort
Copy link
Member

📓 Summary

In order to avoid accidental eager loading of async chunks like in #122941 we want to have an integration test that checks this.

✔️ Acceptance criteria

  • An integration test exists, that fails when any of the infra.chunk.N.js bundles are loaded on the login screen.

💡 Implementation hints

It's not certain this is possible using the webdriver API right now. If it only works for a certain browser we can limit the test case using tags.

@weltenwort weltenwort added Feature:Metrics UI Metrics UI feature Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jan 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@roshan-elastic
Copy link

Hey @weltenwort - this one still need doing?

@weltenwort
Copy link
Member Author

It's still a valid concern IMHO. Whether it's important enough to do any time soon is a different question. 🤷

@smith
Copy link
Contributor

smith commented Jun 15, 2023

Closing. We can reopen if this is causing us problems.

@smith smith closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature info-needed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

4 participants