Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate node version at runtime #12976

Closed
jbudz opened this issue Jul 19, 2017 · 3 comments
Closed

Validate node version at runtime #12976

jbudz opened this issue Jul 19, 2017 · 3 comments
Assignees
@mistic
Labels
good first issue low hanging fruit release_note:enhancement Team:Operations Team label for Operations Team

Comments

@jbudz
Copy link
Member

jbudz commented Jul 19, 2017

We get a decent number of issues filed relating to the wrong version of node running. At this time we make use of SSL constants that will cause issues in < 6, and there are some breaking changes in > 6 that will cause the process to fail. An early failure or warning would help with clearly identifying these errors.
@jbudz jbudz added Team:Operations Team label for Operations Team release_note:enhancement good first issue low hanging fruit labels Jul 19, 2017
@vedularaghu
Copy link
Contributor

I'm a beginner in contributing to kibana. I'm planning to work on this issue. Do you want an early failure or warning?

@vedularaghu vedularaghu mentioned this issue Feb 19, 2018
Closed
@mistic mistic self-assigned this May 8, 2018
@mistic mistic mentioned this issue May 17, 2018
Merged
mistic added a commit to mistic/kibana that referenced this issue May 22, 2018
@mistic
Merge pull request #1 from mistic/node-version-validator-#12976-pr-re…
3da78cb 
…view

Changes requested on PR review for node version validator elastic#12976.
mistic added a commit to mistic/kibana that referenced this issue May 23, 2018
@mistic
Merge branch 'master' into node-version-validator-elastic#12976
121fe0a
mistic added a commit to mistic/kibana that referenced this issue May 23, 2018
@mistic
Merge pull request #2 from mistic/node-version-validator-#12976-pr-re…
fe303ca 
…view

Node version validator elastic#12976 pr review 2
mistic added a commit to mistic/kibana that referenced this issue May 23, 2018
@mistic
Merge branch 'master' into node-version-validator-elastic#12976
ff4dee5
mistic added a commit to mistic/kibana that referenced this issue May 24, 2018
@mistic
Merge branch 'master' into node-version-validator-elastic#12976
0bf6d16
mistic added a commit to mistic/kibana that referenced this issue May 24, 2018
@mistic
Merge pull request #3 from mistic/node-version-validator-#12976-pr-re…
5478934 
…view

Node version validator elastic#12976 pr review 3
mistic added a commit to mistic/kibana that referenced this issue May 24, 2018
@mistic
Merge branch 'node-version-validator-elastic#12976' of github.com:mis…
6e82a1f 
…tic/kibana into node-version-validator-elastic#12976
@tylersmalley
Copy link
Contributor

@mistic, can we close this?

@mistic
Copy link
Member

mistic commented Jul 17, 2018

Yes ofc @tylersmalley I forgot to do it. Closed!

@mistic mistic closed this as completed Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mistic mistic

Labels
good first issue low hanging fruit release_note:enhancement Team:Operations Team label for Operations Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tylersmalley @jbudz @mistic @vedularaghu