Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard context returns invalid filter #13181

Closed
simianhacker opened this issue Jul 28, 2017 · 2 comments · Fixed by #13182
Closed

Dashboard context returns invalid filter #13181

simianhacker opened this issue Jul 28, 2017 · 2 comments · Fixed by #13182
Assignees
@simianhacker
Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) PR sent v6.0.0-beta1 v6.0.0

Comments

@simianhacker
Copy link
Member

simianhacker commented Jul 28, 2017 •
edited
Loading

When there are no fitlers or queries the dashboard context returns an invalid bool filter.

{
  must: [null], 
  must_not: []
}

It needs to check to make sure the filter are not null before they are pushed into the must and must_not arrays. This bug was introduced with #12624

This was originally reported with elastic/beats#4777
@simianhacker simianhacker added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) blocker bug Fixes for quality problems that affect the customer experience v6.0.0 v6.0.0-beta1 labels Jul 28, 2017
@simianhacker
Copy link
Member Author

CC @alexfrancoeur

simianhacker added a commit to simianhacker/kibana that referenced this issue Jul 28, 2017
@simianhacker
Fixes elastic#13181 - Check values before adding them to filter
2575b8e
@simianhacker simianhacker mentioned this issue Jul 28, 2017
Merged
@tsg tsg mentioned this issue Jul 28, 2017
Closed
@epixa epixa added the PR sent label Jul 28, 2017
@lukasolson
Copy link
Member

CC @Bargs

@lukasolson lukasolson assigned Bargs and simianhacker and unassigned Bargs Jul 28, 2017
@thomasneirynck thomasneirynck mentioned this issue Jul 28, 2017
Closed
simianhacker added a commit that referenced this issue Jul 28, 2017
@simianhacker
Add Checks to Dashboard Context (#13182)
b678b4b 
* Fixes #13181 - Check values before adding them to filter

* Adding tests

* Adding check to make sure query is never undefined
simianhacker added a commit that referenced this issue Jul 28, 2017
@simianhacker
Add Checks to Dashboard Context (#13182)
31b3ec2 
* Fixes #13181 - Check values before adding them to filter

* Adding tests

* Adding check to make sure query is never undefined
simianhacker added a commit that referenced this issue Jul 28, 2017
@simianhacker
Add Checks to Dashboard Context (#13182)
9ee0ca8 
* Fixes #13181 - Check values before adding them to filter

* Adding tests

* Adding check to make sure query is never undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simianhacker simianhacker

Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) PR sent v6.0.0-beta1 v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Checks to Dashboard Context simianhacker/kibana
4 participants
@simianhacker @epixa @lukasolson @Bargs