Panel filters get printed in reporting #141536
Labels
bug
Fixes for quality problems that affect the customer experience
(Deprecated) Feature:Reporting
Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead
Feature:Dashboard
Dashboard related features
impact:low
Addressing this issue will have a low level of impact on the quality/strength of our product.
loe:medium
Medium Level of Effort
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
Comments
bhavyarm
added
bug
kibanamachine
added
impact:needs-assessment
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
added
loe:medium
|
Triaged - definitely annoying that this shows up in print mode, since you can't even see what the panel-level filters are! Seems like we could solve this fairly easily by hiding this entire top bar (except the title) from the embeddable panel side when in print mode - this would have the added benefit of hiding any other actions that show up in view/print mode. |
6 tasks
Heenawter
added a commit
that referenced
this issue
Dec 6, 2022
Closes #141536 Closes #143386 ## Summary #136655 introduced a panel level filters badge that would notify users when a visualization was being filtered/queried on an individual panel level. While this exposed important information about how the panels were being generated and made it so that users no longer had to navigate to Lens/Visualize/etc. to see this information, it introduced a lot of undesired clutter to dashboards. This was especially annoying for dashboards in **view** mode, since panel level filter/query information is primarily useful for dashboard authors and thus this badge had minimal benefit despite its large visual impact. To fix this, this PR does three things: 1. Converts the panel filters badge to a single notification icon  2. Displays the filters in a popover rather than a modal  3. Makes this notification icon only visible in **edit** mode - it no longer shows up in view or print mode. ### How to Test 1. Create a visualization with panel level filters and/or queries. - Note that the sample `[Flights] Global Flight Dashboard` dashboard already has some visualizations with panel level filters, so you could also use that instead. 3. Ensure that the panel level filters action icon **only** shows up in edit mode - Swap to view mode and make sure there is no icon - Print a PDF or PNG report and make sure there is no icon 4. Ensure that the `"Edit filters"` button in the popover keeps context when clicked, including allowing you to `"Save and return"` after being taken to Lens/Visualize/etc. 5. Ensure that the contents of the popover react to changes to panel level filters/queries ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Dec 6, 2022
Closes elastic#141536 Closes elastic#143386 ## Summary elastic#136655 introduced a panel level filters badge that would notify users when a visualization was being filtered/queried on an individual panel level. While this exposed important information about how the panels were being generated and made it so that users no longer had to navigate to Lens/Visualize/etc. to see this information, it introduced a lot of undesired clutter to dashboards. This was especially annoying for dashboards in **view** mode, since panel level filter/query information is primarily useful for dashboard authors and thus this badge had minimal benefit despite its large visual impact. To fix this, this PR does three things: 1. Converts the panel filters badge to a single notification icon  2. Displays the filters in a popover rather than a modal  3. Makes this notification icon only visible in **edit** mode - it no longer shows up in view or print mode. ### How to Test 1. Create a visualization with panel level filters and/or queries. - Note that the sample `[Flights] Global Flight Dashboard` dashboard already has some visualizations with panel level filters, so you could also use that instead. 3. Ensure that the panel level filters action icon **only** shows up in edit mode - Swap to view mode and make sure there is no icon - Print a PDF or PNG report and make sure there is no icon 4. Ensure that the `"Edit filters"` button in the popover keeps context when clicked, including allowing you to `"Save and return"` after being taken to Lens/Visualize/etc. 5. Ensure that the contents of the popover react to changes to panel level filters/queries ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit a5d7818)
Heenawter
added a commit
to Heenawter/kibana
that referenced
this issue
Dec 6, 2022
Closes elastic#141536 Closes elastic#143386 elastic#136655 introduced a panel level filters badge that would notify users when a visualization was being filtered/queried on an individual panel level. While this exposed important information about how the panels were being generated and made it so that users no longer had to navigate to Lens/Visualize/etc. to see this information, it introduced a lot of undesired clutter to dashboards. This was especially annoying for dashboards in **view** mode, since panel level filter/query information is primarily useful for dashboard authors and thus this badge had minimal benefit despite its large visual impact. To fix this, this PR does three things: 1. Converts the panel filters badge to a single notification icon  2. Displays the filters in a popover rather than a modal  3. Makes this notification icon only visible in **edit** mode - it no longer shows up in view or print mode. 1. Create a visualization with panel level filters and/or queries. - Note that the sample `[Flights] Global Flight Dashboard` dashboard already has some visualizations with panel level filters, so you could also use that instead. 3. Ensure that the panel level filters action icon **only** shows up in edit mode - Swap to view mode and make sure there is no icon - Print a PDF or PNG report and make sure there is no icon 4. Ensure that the `"Edit filters"` button in the popover keeps context when clicked, including allowing you to `"Save and return"` after being taken to Lens/Visualize/etc. 5. Ensure that the contents of the popover react to changes to panel level filters/queries - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit a5d7818)
kibanamachine
referenced
this issue
Dec 6, 2022
…147134) # Backport This will backport the following commits from `main` to `8.6`: - [[Dashboard] Change panel filters action visibility (#146335)](#146335) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Hannah Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-12-06T18:10:32Z","message":"[Dashboard] Change panel filters action visibility (#146335)\n\nCloses https://github.com/elastic/kibana/issues/141536\r\nCloses https://github.com/elastic/kibana/issues/143386\r\n\r\n## Summary\r\n\r\nhttps://github.com//pull/136655 introduced a panel level\r\nfilters badge that would notify users when a visualization was being\r\nfiltered/queried on an individual panel level. While this exposed\r\nimportant information about how the panels were being generated and made\r\nit so that users no longer had to navigate to Lens/Visualize/etc. to see\r\nthis information, it introduced a lot of undesired clutter to\r\ndashboards. This was especially annoying for dashboards in **view**\r\nmode, since panel level filter/query information is primarily useful for\r\ndashboard authors and thus this badge had minimal benefit despite its\r\nlarge visual impact.\r\n\r\nTo fix this, this PR does three things:\r\n1. Converts the panel filters badge to a single notification icon\r\n \r\n\r\n\r\n\r\n2. Displays the filters in a popover rather than a modal\r\n\r\n\r\n\r\n\r\n\r\n\r\n3. Makes this notification icon only visible in **edit** mode - it no\r\nlonger shows up in view or print mode.\r\n\r\n### How to Test\r\n1. Create a visualization with panel level filters and/or queries.\r\n- Note that the sample `[Flights] Global Flight Dashboard` dashboard\r\nalready has some visualizations with panel level filters, so you could\r\nalso use that instead.\r\n3. Ensure that the panel level filters action icon **only** shows up in\r\nedit mode\r\n - Swap to view mode and make sure there is no icon\r\n - Print a PDF or PNG report and make sure there is no icon\r\n4. Ensure that the `\"Edit filters\"` button in the popover keeps context\r\nwhen clicked, including allowing you to `\"Save and return\"` after being\r\ntaken to Lens/Visualize/etc.\r\n5. Ensure that the contents of the popover react to changes to panel\r\nlevel filters/queries\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a5d781882730902650ee2f870064f0720aaad901","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Dashboard","release_note:fix","Team:Presentation","loe:days","impact:high","backport:all-open","v8.7.0","v8.6.1"],"number":146335,"url":"https://github.com/elastic/kibana/pull/146335","mergeCommit":{"message":"[Dashboard] Change panel filters action visibility (#146335)\n\nCloses https://github.com/elastic/kibana/issues/141536\r\nCloses https://github.com/elastic/kibana/issues/143386\r\n\r\n## Summary\r\n\r\nhttps://github.com//pull/136655 introduced a panel level\r\nfilters badge that would notify users when a visualization was being\r\nfiltered/queried on an individual panel level. While this exposed\r\nimportant information about how the panels were being generated and made\r\nit so that users no longer had to navigate to Lens/Visualize/etc. to see\r\nthis information, it introduced a lot of undesired clutter to\r\ndashboards. This was especially annoying for dashboards in **view**\r\nmode, since panel level filter/query information is primarily useful for\r\ndashboard authors and thus this badge had minimal benefit despite its\r\nlarge visual impact.\r\n\r\nTo fix this, this PR does three things:\r\n1. Converts the panel filters badge to a single notification icon\r\n \r\n\r\n\r\n\r\n2. Displays the filters in a popover rather than a modal\r\n\r\n\r\n\r\n\r\n\r\n\r\n3. Makes this notification icon only visible in **edit** mode - it no\r\nlonger shows up in view or print mode.\r\n\r\n### How to Test\r\n1. Create a visualization with panel level filters and/or queries.\r\n- Note that the sample `[Flights] Global Flight Dashboard` dashboard\r\nalready has some visualizations with panel level filters, so you could\r\nalso use that instead.\r\n3. Ensure that the panel level filters action icon **only** shows up in\r\nedit mode\r\n - Swap to view mode and make sure there is no icon\r\n - Print a PDF or PNG report and make sure there is no icon\r\n4. Ensure that the `\"Edit filters\"` button in the popover keeps context\r\nwhen clicked, including allowing you to `\"Save and return\"` after being\r\ntaken to Lens/Visualize/etc.\r\n5. Ensure that the contents of the popover react to changes to panel\r\nlevel filters/queries\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a5d781882730902650ee2f870064f0720aaad901"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146335","number":146335,"mergeCommit":{"message":"[Dashboard] Change panel filters action visibility (#146335)\n\nCloses https://github.com/elastic/kibana/issues/141536\r\nCloses https://github.com/elastic/kibana/issues/143386\r\n\r\n## Summary\r\n\r\nhttps://github.com//pull/136655 introduced a panel level\r\nfilters badge that would notify users when a visualization was being\r\nfiltered/queried on an individual panel level. While this exposed\r\nimportant information about how the panels were being generated and made\r\nit so that users no longer had to navigate to Lens/Visualize/etc. to see\r\nthis information, it introduced a lot of undesired clutter to\r\ndashboards. This was especially annoying for dashboards in **view**\r\nmode, since panel level filter/query information is primarily useful for\r\ndashboard authors and thus this badge had minimal benefit despite its\r\nlarge visual impact.\r\n\r\nTo fix this, this PR does three things:\r\n1. Converts the panel filters badge to a single notification icon\r\n \r\n\r\n\r\n\r\n2. Displays the filters in a popover rather than a modal\r\n\r\n\r\n\r\n\r\n\r\n\r\n3. Makes this notification icon only visible in **edit** mode - it no\r\nlonger shows up in view or print mode.\r\n\r\n### How to Test\r\n1. Create a visualization with panel level filters and/or queries.\r\n- Note that the sample `[Flights] Global Flight Dashboard` dashboard\r\nalready has some visualizations with panel level filters, so you could\r\nalso use that instead.\r\n3. Ensure that the panel level filters action icon **only** shows up in\r\nedit mode\r\n - Swap to view mode and make sure there is no icon\r\n - Print a PDF or PNG report and make sure there is no icon\r\n4. Ensure that the `\"Edit filters\"` button in the popover keeps context\r\nwhen clicked, including allowing you to `\"Save and return\"` after being\r\ntaken to Lens/Visualize/etc.\r\n5. Ensure that the contents of the popover react to changes to panel\r\nlevel filters/queries\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a5d781882730902650ee2f870064f0720aaad901"}},{"branch":"8.6","label":"v8.6.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
\r\n\r\n2){kind=link}
\r\n\r\n\r\n3){kind=link}
Heenawter
referenced
this issue
Dec 7, 2022
…147135) # Backport This will backport the following commits from `main` to `8.5`: - [[Dashboard] Change panel filters action visibility (#146335)](#146335) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Hannah Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-12-06T18:10:32Z","message":"[Dashboard] Change panel filters action visibility (#146335)\n\nCloses https://github.com/elastic/kibana/issues/141536\r\nCloses https://github.com/elastic/kibana/issues/143386\r\n\r\n## Summary\r\n\r\nhttps://github.com//pull/136655 introduced a panel level\r\nfilters badge that would notify users when a visualization was being\r\nfiltered/queried on an individual panel level. While this exposed\r\nimportant information about how the panels were being generated and made\r\nit so that users no longer had to navigate to Lens/Visualize/etc. to see\r\nthis information, it introduced a lot of undesired clutter to\r\ndashboards. This was especially annoying for dashboards in **view**\r\nmode, since panel level filter/query information is primarily useful for\r\ndashboard authors and thus this badge had minimal benefit despite its\r\nlarge visual impact.\r\n\r\nTo fix this, this PR does three things:\r\n1. Converts the panel filters badge to a single notification icon\r\n \r\n\r\n\r\n\r\n2. Displays the filters in a popover rather than a modal\r\n\r\n\r\n\r\n\r\n\r\n\r\n3. Makes this notification icon only visible in **edit** mode - it no\r\nlonger shows up in view or print mode.\r\n\r\n### How to Test\r\n1. Create a visualization with panel level filters and/or queries.\r\n- Note that the sample `[Flights] Global Flight Dashboard` dashboard\r\nalready has some visualizations with panel level filters, so you could\r\nalso use that instead.\r\n3. Ensure that the panel level filters action icon **only** shows up in\r\nedit mode\r\n - Swap to view mode and make sure there is no icon\r\n - Print a PDF or PNG report and make sure there is no icon\r\n4. Ensure that the `\"Edit filters\"` button in the popover keeps context\r\nwhen clicked, including allowing you to `\"Save and return\"` after being\r\ntaken to Lens/Visualize/etc.\r\n5. Ensure that the contents of the popover react to changes to panel\r\nlevel filters/queries\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a5d781882730902650ee2f870064f0720aaad901","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Dashboard","release_note:fix","Team:Presentation","loe:days","impact:high","backport:all-open","v8.7.0","v8.6.1"],"number":146335,"url":"https://github.com/elastic/kibana/pull/146335","mergeCommit":{"message":"[Dashboard] Change panel filters action visibility (#146335)\n\nCloses https://github.com/elastic/kibana/issues/141536\r\nCloses https://github.com/elastic/kibana/issues/143386\r\n\r\n## Summary\r\n\r\nhttps://github.com//pull/136655 introduced a panel level\r\nfilters badge that would notify users when a visualization was being\r\nfiltered/queried on an individual panel level. While this exposed\r\nimportant information about how the panels were being generated and made\r\nit so that users no longer had to navigate to Lens/Visualize/etc. to see\r\nthis information, it introduced a lot of undesired clutter to\r\ndashboards. This was especially annoying for dashboards in **view**\r\nmode, since panel level filter/query information is primarily useful for\r\ndashboard authors and thus this badge had minimal benefit despite its\r\nlarge visual impact.\r\n\r\nTo fix this, this PR does three things:\r\n1. Converts the panel filters badge to a single notification icon\r\n \r\n\r\n\r\n\r\n2. Displays the filters in a popover rather than a modal\r\n\r\n\r\n\r\n\r\n\r\n\r\n3. Makes this notification icon only visible in **edit** mode - it no\r\nlonger shows up in view or print mode.\r\n\r\n### How to Test\r\n1. Create a visualization with panel level filters and/or queries.\r\n- Note that the sample `[Flights] Global Flight Dashboard` dashboard\r\nalready has some visualizations with panel level filters, so you could\r\nalso use that instead.\r\n3. Ensure that the panel level filters action icon **only** shows up in\r\nedit mode\r\n - Swap to view mode and make sure there is no icon\r\n - Print a PDF or PNG report and make sure there is no icon\r\n4. Ensure that the `\"Edit filters\"` button in the popover keeps context\r\nwhen clicked, including allowing you to `\"Save and return\"` after being\r\ntaken to Lens/Visualize/etc.\r\n5. Ensure that the contents of the popover react to changes to panel\r\nlevel filters/queries\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a5d781882730902650ee2f870064f0720aaad901"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146335","number":146335,"mergeCommit":{"message":"[Dashboard] Change panel filters action visibility (#146335)\n\nCloses https://github.com/elastic/kibana/issues/141536\r\nCloses https://github.com/elastic/kibana/issues/143386\r\n\r\n## Summary\r\n\r\nhttps://github.com//pull/136655 introduced a panel level\r\nfilters badge that would notify users when a visualization was being\r\nfiltered/queried on an individual panel level. While this exposed\r\nimportant information about how the panels were being generated and made\r\nit so that users no longer had to navigate to Lens/Visualize/etc. to see\r\nthis information, it introduced a lot of undesired clutter to\r\ndashboards. This was especially annoying for dashboards in **view**\r\nmode, since panel level filter/query information is primarily useful for\r\ndashboard authors and thus this badge had minimal benefit despite its\r\nlarge visual impact.\r\n\r\nTo fix this, this PR does three things:\r\n1. Converts the panel filters badge to a single notification icon\r\n \r\n\r\n\r\n\r\n2. Displays the filters in a popover rather than a modal\r\n\r\n\r\n\r\n\r\n\r\n\r\n3. Makes this notification icon only visible in **edit** mode - it no\r\nlonger shows up in view or print mode.\r\n\r\n### How to Test\r\n1. Create a visualization with panel level filters and/or queries.\r\n- Note that the sample `[Flights] Global Flight Dashboard` dashboard\r\nalready has some visualizations with panel level filters, so you could\r\nalso use that instead.\r\n3. Ensure that the panel level filters action icon **only** shows up in\r\nedit mode\r\n - Swap to view mode and make sure there is no icon\r\n - Print a PDF or PNG report and make sure there is no icon\r\n4. Ensure that the `\"Edit filters\"` button in the popover keeps context\r\nwhen clicked, including allowing you to `\"Save and return\"` after being\r\ntaken to Lens/Visualize/etc.\r\n5. Ensure that the contents of the popover react to changes to panel\r\nlevel filters/queries\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a5d781882730902650ee2f870064f0720aaad901"}},{"branch":"8.6","label":"v8.6.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/147134","number":147134,"state":"OPEN"}]}] BACKPORT--> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kibana version: 8.5.0 BC1
Elasticsearch version: 8.5.0 BC1
Server OS version: darwin_x86_64
Browser version: chrome latest
Browser OS version: OS X
Original install method (e.g. download page, yum, from source, etc.): from staging
Describe the bug: Panel filters get printed on reports.
The text was updated successfully, but these errors were encountered: