Failing test: Jest Tests.x-pack/plugins/cases/public/components/create - Create case Step 2 - Connector Fields should submit and push to resilient connector #143408

kibanamachine · 2022-10-14T21:25:43Z

A test failed on a tracked branch

TestingLibraryElementError: Unable to find an element by: [data-test-subj="caseTitle"]

Ignored nodes: comments, <script />, <style />
<body
  class=""
>
  <div />
</body>
    at Object.getElementError (/var/lib/buildkite-agent/builds/kb-n2-4-spot-44d53f83b83faf14/elastic/kibana-on-merge/kibana/node_modules/@testing-library/dom/dist/config.js:38:19)
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-44d53f83b83faf14/elastic/kibana-on-merge/kibana/node_modules/@testing-library/dom/dist/query-helpers.js:90:38
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-44d53f83b83faf14/elastic/kibana-on-merge/kibana/node_modules/@testing-library/dom/dist/query-helpers.js:62:17
    at getByTestId (/var/lib/buildkite-agent/builds/kb-n2-4-spot-44d53f83b83faf14/elastic/kibana-on-merge/kibana/node_modules/@testing-library/dom/dist/query-helpers.js:111:19)
    at fillFormReactTestingLib (/var/lib/buildkite-agent/builds/kb-n2-4-spot-44d53f83b83faf14/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/create/form_context.test.tsx:104:42)
    at Object.<anonymous> (/var/lib/buildkite-agent/builds/kb-n2-4-spot-44d53f83b83faf14/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/create/form_context.test.tsx:502:13)
    at Promise.then.completed (/var/lib/buildkite-agent/builds/kb-n2-4-spot-44d53f83b83faf14/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/utils.js:276:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/buildkite-agent/builds/kb-n2-4-spot-44d53f83b83faf14/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/utils.js:216:10)
    at _callCircusTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-44d53f83b83faf14/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:212:40)
    at runNextTicks (node:internal/process/task_queues:61:5)
    at processTimers (node:internal/timers:499:9)
    at _runTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-44d53f83b83faf14/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-44d53f83b83faf14/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-44d53f83b83faf14/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:57:9)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-44d53f83b83faf14/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/buildkite-agent/builds/kb-n2-4-spot-44d53f83b83faf14/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/buildkite-agent/builds/kb-n2-4-spot-44d53f83b83faf14/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/buildkite-agent/builds/kb-n2-4-spot-44d53f83b83faf14/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/buildkite-agent/builds/kb-n2-4-spot-44d53f83b83faf14/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-44d53f83b83faf14/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:472:34)

First failure: CI Build - main

The text was updated successfully, but these errors were encountered:

elasticmachine · 2022-10-14T21:26:15Z

Pinging @elastic/response-ops (Team:ResponseOps)

## Summary This PR fixes a number of issues with the same error: `TestingLibraryElementError: Unable to find an element by: [data-test-subj="caseTitle"]`. The PR: - Clears unnecessary `act` - Wait for the form to render before trying to fill the form - Wait for the component to update all states to eliminate warnings - Fill tags when necessary to improve tests execution time - Replace `userEvent.type` with `userEvent.aste` when possible to improve execution time - Add `skipPointerEventsCheck: true` when necessary I run the test file 100 times locally without any errors. Fixes: #142287, #142288, #142285, #142286, #142284, #142283, #142282, #142281, #143407, #143406, #143405, #143408, #143403 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

## Summary This PR fixes a number of issues with the same error: `TestingLibraryElementError: Unable to find an element by: [data-test-subj="caseTitle"]`. The PR: - Clears unnecessary `act` - Wait for the form to render before trying to fill the form - Wait for the component to update all states to eliminate warnings - Fill tags when necessary to improve tests execution time - Replace `userEvent.type` with `userEvent.aste` when possible to improve execution time - Add `skipPointerEventsCheck: true` when necessary I run the test file 100 times locally without any errors. Fixes: elastic#142287, elastic#142288, elastic#142285, elastic#142286, elastic#142284, elastic#142283, elastic#142282, elastic#142281, elastic#143407, elastic#143406, elastic#143405, elastic#143408, elastic#143403 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 6936644)

## Summary This PR fixes a number of issues with the same error: `TestingLibraryElementError: Unable to find an element by: [data-test-subj="caseTitle"]`. The PR: - Clears unnecessary `act` - Wait for the form to render before trying to fill the form - Wait for the component to update all states to eliminate warnings - Fill tags when necessary to improve tests execution time - Replace `userEvent.type` with `userEvent.aste` when possible to improve execution time - Add `skipPointerEventsCheck: true` when necessary I run the test file 100 times locally without any errors. Fixes: elastic#142287, elastic#142288, elastic#142285, elastic#142286, elastic#142284, elastic#142283, elastic#142282, elastic#142281, elastic#143407, elastic#143406, elastic#143405, elastic#143408, elastic#143403 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

kibanamachine · 2022-11-23T20:43:08Z

New failure: CI Build - 8.6

tylersmalley · 2022-11-23T20:53:02Z

@cnasikas, can we also get this backported, or would you prefer we skipped for 8.6?

kibanamachine · 2022-11-23T22:38:45Z

New failure: CI Build - 8.6

cnasikas · 2022-11-24T07:55:27Z

@tylersmalley I backported the fix in #146213.

kibanamachine · 2022-11-24T11:24:30Z

New failure: CI Build - 8.6

kibanamachine · 2022-11-24T11:26:12Z

New failure: CI Build - 8.6

mistic · 2022-11-24T18:17:27Z

Skipped.

8.6: 69c72cb

kibanamachine · 2022-11-28T13:34:22Z

New failure: CI Build - main

mistic · 2022-11-28T18:23:24Z

Skipped.

main: 48924de

## Summary This PR converts all connector forms to use the form lib. Fixes: #133467, #143408, #146394 ## Notable changes - All connector's hooks were converted to use React Query - All connector's forms were converted to use the Kibana Form Lib - The form of fields of the connector and the preview of the fields of the connector got separated - All connector logic in the case view page moved on its own component - Improve loading visualization on the first render - Jira: Issue type is not selected automatically - Jira: Added validation for the issue type field - ServiceNow: Subcategory is visible ## Testing scenarios - Create a case with no connectors. Press "Add connector". The Save button should be disabled - Create a case (or edit an existing one) with a connector. Press the edit pencil. The Save button should be disabled - Create a case (or edit an existing one) with a connector. Press the edit pencil. Change a field or a connector. The Save button should not be disabled - Change various connectors and their fields on a case. The fields should be preserved between changes - Change various connectors and their fields on a case - Test the forms of all supported connectors in the create case and the view case page - Push all supported connectors in the create case and the view case page and verify it is working as expected - Optional fields can be pushed correctly - Check that the fields are being reset when changing connectors of the same type (Jira for example) - Test that connectors work in the create case form when attaching outside of Cases (ML for example) - Jira: Try to submit without an issue type selected. You should see an error - ServiceNow: Test that the subcategory is being reset when you change the category. ## Flaky tests The PR fixes the flaky tests in `x-pack/plugins/cases/public/components/create/form_context.test.tsx`. I run the test multiple times on CI to ensure that the test is not flaky anymore: Specifically: - Test run 50 times in f220cc3 - Test run 55 times in 6221314 - Test run 50 times in 9155163 ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

## Summary This PR converts all connector forms to use the form lib. Fixes: elastic#133467, elastic#143408, elastic#146394 ## Notable changes - All connector's hooks were converted to use React Query - All connector's forms were converted to use the Kibana Form Lib - The form of fields of the connector and the preview of the fields of the connector got separated - All connector logic in the case view page moved on its own component - Improve loading visualization on the first render - Jira: Issue type is not selected automatically - Jira: Added validation for the issue type field - ServiceNow: Subcategory is visible ## Testing scenarios - Create a case with no connectors. Press "Add connector". The Save button should be disabled - Create a case (or edit an existing one) with a connector. Press the edit pencil. The Save button should be disabled - Create a case (or edit an existing one) with a connector. Press the edit pencil. Change a field or a connector. The Save button should not be disabled - Change various connectors and their fields on a case. The fields should be preserved between changes - Change various connectors and their fields on a case - Test the forms of all supported connectors in the create case and the view case page - Push all supported connectors in the create case and the view case page and verify it is working as expected - Optional fields can be pushed correctly - Check that the fields are being reset when changing connectors of the same type (Jira for example) - Test that connectors work in the create case form when attaching outside of Cases (ML for example) - Jira: Try to submit without an issue type selected. You should see an error - ServiceNow: Test that the subcategory is being reset when you change the category. ## Flaky tests The PR fixes the flaky tests in `x-pack/plugins/cases/public/components/create/form_context.test.tsx`. I run the test multiple times on CI to ensure that the test is not flaky anymore: Specifically: - Test run 50 times in elastic@f220cc3 - Test run 55 times in elastic@6221314 - Test run 50 times in elastic@9155163 ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Oct 14, 2022

botelastic bot added the needs-team Issues missing a team label label Oct 14, 2022

kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Oct 14, 2022

botelastic bot removed the needs-team Issues missing a team label label Oct 14, 2022

cnasikas added the Feature:Cases Cases feature label Oct 17, 2022

cnasikas mentioned this issue Nov 15, 2022

[Cases] Fix flaky tests in the create case form #145211

Merged

2 tasks

cnasikas self-assigned this Nov 15, 2022

cnasikas linked a pull request Nov 15, 2022 that will close this issue

[Cases] Fix flaky tests in the create case form #145211

Merged

2 tasks

cnasikas closed this as completed in #145211 Nov 16, 2022

kibanamachine reopened this Nov 23, 2022

cnasikas closed this as completed Nov 24, 2022

kibanamachine reopened this Nov 24, 2022

mistic added a commit that referenced this issue Nov 24, 2022

skip flaky suite (#143408)

69c72cb

mistic added blocker skipped-test v8.6.1 labels Nov 24, 2022

mistic added a commit that referenced this issue Nov 28, 2022

skip flaky suite (#143408)

48924de

mistic added the v8.7.0 label Nov 28, 2022

cnasikas mentioned this issue Feb 12, 2023

[Cases] Fix case creation flaky tests #150960

Closed

2 tasks

cnasikas linked a pull request Feb 12, 2023 that will close this issue

[Cases] Fix case creation flaky tests #150960

Closed

2 tasks

cnasikas removed a link to a pull request Feb 12, 2023

[Cases] Fix flaky tests in the create case form #145211

Merged

2 tasks

cnasikas added v8.8.0 and removed blocker v8.7.0 v8.6.1 labels Mar 5, 2023

cnasikas mentioned this issue May 14, 2023

[Cases] Refactor connectors to use the form lib #157380

Merged

3 tasks

cnasikas removed a link to a pull request May 14, 2023

[Cases] Fix case creation flaky tests #150960

Closed

2 tasks

cnasikas linked a pull request May 14, 2023 that will close this issue

[Cases] Refactor connectors to use the form lib #157380

Merged

3 tasks

cnasikas removed the v8.8.0 label May 16, 2023

cnasikas closed this as completed in #157380 May 22, 2023

kibanamachine removed the skipped-test label May 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Failing test: Jest Tests.x-pack/plugins/cases/public/components/create - Create case Step 2 - Connector Fields should submit and push to resilient connector #143408

Failing test: Jest Tests.x-pack/plugins/cases/public/components/create - Create case Step 2 - Connector Fields should submit and push to resilient connector #143408

kibanamachine commented Oct 14, 2022 •

edited

Loading

elasticmachine commented Oct 14, 2022

kibanamachine commented Nov 23, 2022

tylersmalley commented Nov 23, 2022

kibanamachine commented Nov 23, 2022

cnasikas commented Nov 24, 2022

kibanamachine commented Nov 24, 2022

kibanamachine commented Nov 24, 2022

mistic commented Nov 24, 2022

kibanamachine commented Nov 28, 2022

mistic commented Nov 28, 2022

Failing test: Jest Tests.x-pack/plugins/cases/public/components/create - Create case Step 2 - Connector Fields should submit and push to resilient connector #143408

Failing test: Jest Tests.x-pack/plugins/cases/public/components/create - Create case Step 2 - Connector Fields should submit and push to resilient connector #143408

Comments

kibanamachine commented Oct 14, 2022 • edited Loading

elasticmachine commented Oct 14, 2022

kibanamachine commented Nov 23, 2022

tylersmalley commented Nov 23, 2022

kibanamachine commented Nov 23, 2022

cnasikas commented Nov 24, 2022

kibanamachine commented Nov 24, 2022

kibanamachine commented Nov 24, 2022

mistic commented Nov 24, 2022

kibanamachine commented Nov 28, 2022

mistic commented Nov 28, 2022

kibanamachine commented Oct 14, 2022 •

edited

Loading