Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAM] Update task runner to support new consolidated statuses #143460

Closed
JiaweiWu opened this issue Oct 17, 2022 · 1 comment
Closed

[RAM] Update task runner to support new consolidated statuses #143460

JiaweiWu opened this issue Oct 17, 2022 · 1 comment
Assignees
Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.0

Comments

@JiaweiWu
Copy link
Contributor

Parent issue: #136039

Update the alerting task runner to support consolidated statuses. Ensuring the task runner is correctly updating the new rule saved objects schema (the new last_run field and last_run monitoring fields).

@JiaweiWu JiaweiWu added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesManagement Issues related to the Rules Management UX v8.6.0 labels Oct 17, 2022
@JiaweiWu JiaweiWu self-assigned this Oct 17, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

XavierM added a commit that referenced this issue Nov 14, 2022
## Summary

Resolves the parent issue:
#136039

Also resolves the subtasks:
 - #143461
 - #143460

This is the backend portion of the consolidated rule status feature. It
mainly contains changes to the `rules_client.ts` and `task_runner.ts` to
support the new consolidated rule statuses.

This PR added a new property: `lastRun` to the rules saved object to
hold the new rule outcome statuses (`succeeded`, `warning`, and
`failed`) as the new simplified rule status over the existing
`executionStatus` property. However, we are keeping the old
`executionStatus` so we can slowly migrate the rest of the application
to use the new `lastRun` outcomes.

In addition, we have enriched the `monitoring` property to be the source
of truth for metrics related to the last run (as well as new fields that
other plugins will find useful). We also added a monitoring service that
allows other plugins to easily add data to the monitoring field.

To test this PR, please use
#144466 since it has both the
frontend and backend changes.

### Checklist
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jiawei Wu <jiawei.wu@cmd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.0
Projects
No open projects
Development

No branches or pull requests

2 participants