Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Guided onboarding] Add cloud check to the API service #144515

Closed
yuliacech opened this issue Nov 3, 2022 · 1 comment · Fixed by #144634
Closed

[Guided onboarding] Add cloud check to the API service #144515

yuliacech opened this issue Nov 3, 2022 · 1 comment · Fixed by #144634
Labels
enhancement New value added to drive a business result Team:Journey/Onboarding Platform Journey Onboarding team

Comments

@yuliacech
Copy link
Contributor

Follow up to #144160 and #143808

Guided onboarding UI is only available on Cloud deployments, but on self managed the API service will still try to send API requests when any functions are used. We need to add a check that would prevent any API requests when not on Cloud.

Related #139798
@yuliacech yuliacech added enhancement New value added to drive a business result Team:Journey/Onboarding Platform Journey Onboarding team labels Nov 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-onboarding (Team:Journey/Onboarding)

@yuliacech yuliacech mentioned this issue Nov 10, 2022
Merged
2 tasks
yuliacech added a commit that referenced this issue Nov 14, 2022
@yuliacech @kibanamachine
[Guided onboarding] Update header button logic (#144634)
879b101 
## Summary
Fixes #141129
Fixes #144515

This PR introduces a new state to the guided onboarding plugin. The
state keeps track of the `creationDate` and of the overall `status` of
the plugin. The creation date allows us to detect an "active" period
during which the header button will be displayed more prominently in the
header. Currently, the active period is set to 30 days. During this
time, if the user has not started any guide, has quit a guide before
completion or skipped the guide on the landing page, the header button
will be displayed and when clicked, redirect the user to the landing
page to start/continue a guide.
Also this PR adds a check for Cloud deployments and prevents the code
from sending any API requests when not on Cloud, because guided
onboarding is disabled on prem.

#### Screenshot 
<img width="298" alt="Screenshot 2022-11-10 at 18 42 18"
src="https://user-images.githubusercontent.com/6585477/201168414-391a7cd4-0709-492b-9001-1432b5bed3c8.png">



### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Team:Journey/Onboarding Platform Journey Onboarding team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Guided onboarding] Update header button logic yuliacech/kibana
2 participants
@yuliacech @elasticmachine