Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Overview - Flyout - URL is displayed for TCP and ICMP monitors #144854

Closed
dominiqueclarke opened this issue Nov 8, 2022 · 1 comment · Fixed by #145938
Closed

[Synthetics] Overview - Flyout - URL is displayed for TCP and ICMP monitors #144854

dominiqueclarke opened this issue Nov 8, 2022 · 1 comment · Fixed by #145938
Assignees
@justinkambic
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.6.0

Comments

@dominiqueclarke
Copy link
Contributor

URL (empty) is displayed for TCP and ICMP monitors. Instead, we should display host.

Screen Shot 2022-11-08 at 3 59 49 PM

Steps to reproduce:

  1. Navigate to Synthetics app
  2. Create a TCP monitor
  3. Open the monitor flyout on the Overview page
  4. Notice URL (empty) is displayed instead of Hosts
@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.6.0 labels Nov 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@justinkambic justinkambic mentioned this issue Nov 21, 2022
Merged
@justinkambic justinkambic self-assigned this Nov 21, 2022
justinkambic added a commit that referenced this issue Nov 23, 2022
@justinkambic @kibanamachine
[Synthetics] Hide URL field when value is falsey (#145938)
78f2209 
## Summary

Resolves #144855.

Resolves #144854.

Hides the URL field when it has no value, like in the case of multistep
monitors.

## Testing this PR

Create a multistep monitor that will not have a URL field, and view the
flyout for your monitor. See that there is no URL field displayed.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 23, 2022
@justinkambic
[Synthetics] Hide URL field when value is falsey (elastic#145938)
86415d7 
## Summary

Resolves elastic#144855.

Resolves elastic#144854.

Hides the URL field when it has no value, like in the case of multistep
monitors.

## Testing this PR

Create a multistep monitor that will not have a URL field, and view the
flyout for your monitor. See that there is no URL field displayed.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 78f2209)
kibanamachine added a commit that referenced this issue Nov 23, 2022
@kibanamachine @justinkambic
[8.6] [Synthetics] Hide URL field when value is falsey (#145938) (#14…
d458b8f 
…6156)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Synthetics] Hide URL field when value is falsey
(#145938)](#145938)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Justin
Kambic","email":"jk@elastic.co"},"sourceCommit":{"committedDate":"2022-11-23T14:32:30Z","message":"[Synthetics]
Hide URL field when value is falsey (#145938)\n\n##
Summary\r\n\r\nResolves #144855.\r\n\r\nResolves #144854.\r\n\r\nHides
the URL field when it has no value, like in the case of
multistep\r\nmonitors.\r\n\r\n## Testing this PR\r\n\r\nCreate a
multistep monitor that will not have a URL field, and view the\r\nflyout
for your monitor. See that there is no URL field
displayed.\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"78f22099436519dc8c069d12d21f9a90b3a6eb92","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","v8.6.0","v8.7.0"],"number":145938,"url":"https://github.com/elastic/kibana/pull/145938","mergeCommit":{"message":"[Synthetics]
Hide URL field when value is falsey (#145938)\n\n##
Summary\r\n\r\nResolves #144855.\r\n\r\nResolves #144854.\r\n\r\nHides
the URL field when it has no value, like in the case of
multistep\r\nmonitors.\r\n\r\n## Testing this PR\r\n\r\nCreate a
multistep monitor that will not have a URL field, and view the\r\nflyout
for your monitor. See that there is no URL field
displayed.\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"78f22099436519dc8c069d12d21f9a90b3a6eb92"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145938","number":145938,"mergeCommit":{"message":"[Synthetics]
Hide URL field when value is falsey (#145938)\n\n##
Summary\r\n\r\nResolves #144855.\r\n\r\nResolves #144854.\r\n\r\nHides
the URL field when it has no value, like in the case of
multistep\r\nmonitors.\r\n\r\n## Testing this PR\r\n\r\nCreate a
multistep monitor that will not have a URL field, and view the\r\nflyout
for your monitor. See that there is no URL field
displayed.\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"78f22099436519dc8c069d12d21f9a90b3a6eb92"}}]}]
BACKPORT-->

Co-authored-by: Justin Kambic <jk@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinkambic justinkambic

Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Synthetics] Hide URL field when value is falsey justinkambic/kibana
3 participants
@dominiqueclarke @elasticmachine @justinkambic