Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TriggersActionsUi] Regularly Failing Jest Config #145188

Closed
mistic opened this issue Nov 14, 2022 · 4 comments
Closed

[TriggersActionsUi] Regularly Failing Jest Config #145188

mistic opened this issue Nov 14, 2022 · 4 comments
Assignees
Labels
blocker skipped-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.7.0

Comments

@mistic
Copy link
Member

mistic commented Nov 14, 2022

The x-pack/plugins/triggers_actions_ui/jest.config.js jest config has shown to be problematic recently.

The error is being thrown during the run of this test suite on CI and logs as following (example):

var evt = document.createEvent('Event');
                   ^
TypeError: Cannot read properties of null (reading 'createEvent')

I'm not sure about what could be causing this but I think the warnings and console.errors that are being logged when running this suite could be a good place to start the investigation. For now, I'm just skipping the suite so you can have a look on those. Because of this non of the "unit" tests in the TriggersActionsUi plugin are being executed automatically. This can definitely lead to issues in future versions of Kibana if these tests are not fixed ASAP.

To unskip this test just remove the "x-pack/plugins/triggers_actions_ui/jest.config.js" item in .buildkite/disabled_jest_configs.json

Related to #144445

@mistic mistic added blocker skipped-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.7.0 labels Nov 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

mistic added a commit that referenced this issue Nov 14, 2022
This PR disables the jest config on CI for `triggers_actions_ui` plugin
as it has been failing regularly during the entire day.

We are not sure about what is the problem but when running this test
suite the CI is logging `console.error` multiple times across many test
files warning around tests not being properly wrapped or using
unsupported syntax. Those should be fixed by the owning teams and I've
opened an issue for that at
#145188
@mikecote
Copy link
Contributor

@XavierM I recall R&AM doing some work around the jest tests, is this issue covered already?

@jcger
Copy link
Contributor

jcger commented Jan 11, 2023

FYI Dec 14th we activated most of the test here and yesterday Jan 10th we activated everything except for two tests here.

We still want to fix those last two tests before closing this issue

@XavierM
Copy link
Contributor

XavierM commented Feb 28, 2023

with this PR merged we can close this issue

@XavierM XavierM closed this as completed Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker skipped-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.7.0
Projects
No open projects
Development

No branches or pull requests

5 participants