Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] "Add exceptions to this rule" is showing for Exception list. #145673

Closed
ghost opened this issue Nov 18, 2022 · 3 comments
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Rule Exceptions Security Solution Rule Exceptions feature fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0

Comments

@ghost
Copy link

ghost commented Nov 18, 2022

Describe the bug:
Add exceptions to this rule is showing for Exception list.

Build Details:

Version: 8.6.0 BC1
Build:47054
Commit: 9fb16d54c520392b933846e902a7afd9520a8a87

Preconditions:

  1. Elasticsearch should be up and running
  2. Kibana should be up and running

Steps to Reproduce:

  1. Navigate to Security-->Manage-->Rule exceptions.
  2. Create shared exception list.
  3. Expand the exception list.

Expected Result:
Text should be like add Exception item to the exception list.

Actual Result:
"Add exceptions to this rule" is showing for Exception list.

Screenshots:
Annotation 2022-11-18 113659

@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team v8.6.0 labels Nov 18, 2022
@ghost ghost self-assigned this Nov 18, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost
Copy link
Author

ghost commented Nov 18, 2022

Please review @deepikakeshav-qasource

@ghost ghost assigned MadameSheema and unassigned ghost Nov 18, 2022
@MadameSheema MadameSheema added the Team:Security Solution Platform Security Solution Platform Team label Nov 18, 2022
@WafaaNasr WafaaNasr assigned WafaaNasr and unassigned dhurley14 Nov 18, 2022
@peluja1012 peluja1012 added Feature:Rule Exceptions Security Solution Rule Exceptions feature and removed triage_needed labels Nov 18, 2022
@nkhristinin nkhristinin assigned nkhristinin and unassigned WafaaNasr Nov 21, 2022
nkhristinin added a commit that referenced this issue Nov 21, 2022
## Summary

Address: 
[145806](#145806), 
[145535](#145535), 
[145541](#145541), 
[145676](#145676), 
[145673](#145673), 





https://user-images.githubusercontent.com/7609147/203031829-bcbd5db2-e9af-4ef6-ad8d-0016c33b785b.mov



### Checklist

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 21, 2022
## Summary

Address:
[145806](elastic#145806),
[145535](elastic#145535),
[145541](elastic#145541),
[145676](elastic#145676),
[145673](elastic#145673),

https://user-images.githubusercontent.com/7609147/203031829-bcbd5db2-e9af-4ef6-ad8d-0016c33b785b.mov

### Checklist

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit f24e75d)
kibanamachine added a commit that referenced this issue Nov 21, 2022
# Backport

This will backport the following commits from `main` to `8.6`:
- [Endpoint fixes
(#145834)](#145834)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Khristinin
Nikita","email":"nikita.khristinin@elastic.co"},"sourceCommit":{"committedDate":"2022-11-21T17:37:35Z","message":"Endpoint
fixes (#145834)\n\n## Summary\r\n\r\nAddress:
\r\n[145806](#145806),
\r\n[145535](#145535),
\r\n[145541](#145541),
\r\n[145676](#145676),
\r\n[145673](#145673),
\r\n\r\n\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/7609147/203031829-bcbd5db2-e9af-4ef6-ad8d-0016c33b785b.mov\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"f24e75d3920d71806d588d281d433737012373c9","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Security
Solution
Platform","backport:prev-minor","v8.7.0"],"number":145834,"url":"https://github.com/elastic/kibana/pull/145834","mergeCommit":{"message":"Endpoint
fixes (#145834)\n\n## Summary\r\n\r\nAddress:
\r\n[145806](#145806),
\r\n[145535](#145535),
\r\n[145541](#145541),
\r\n[145676](#145676),
\r\n[145673](#145673),
\r\n\r\n\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/7609147/203031829-bcbd5db2-e9af-4ef6-ad8d-0016c33b785b.mov\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"f24e75d3920d71806d588d281d433737012373c9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145834","number":145834,"mergeCommit":{"message":"Endpoint
fixes (#145834)\n\n## Summary\r\n\r\nAddress:
\r\n[145806](#145806),
\r\n[145535](#145535),
\r\n[145541](#145541),
\r\n[145676](#145676),
\r\n[145673](#145673),
\r\n\r\n\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/7609147/203031829-bcbd5db2-e9af-4ef6-ad8d-0016c33b785b.mov\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"f24e75d3920d71806d588d281d433737012373c9"}}]}]
BACKPORT-->

Co-authored-by: Khristinin Nikita <nikita.khristinin@elastic.co>
@ghost
Copy link
Author

ghost commented Nov 24, 2022

Hi Team,

We have validated above issue on 8.6.0 BC2 and it's working fine. 🟢

Build Details:

VERSION: 8.6.0 BC2
BUILD: 58485
COMMIT: b52b34c2ff5216c395bd49c5fbc97744b646f34d

Screenshots:

Annotation 2022-11-24 134616

@ghost ghost closed this as completed Nov 24, 2022
@ghost ghost added the QA:Validated Issue has been validated by QA label Nov 24, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Rule Exceptions Security Solution Rule Exceptions feature fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0
Projects
None yet
Development

No branches or pull requests

6 participants