Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Make fleet optional again: Inject API key into APM Integration policy #146368

Closed
sorenlouv opened this issue Nov 28, 2022 · 2 comments · Fixed by #147650
Closed

[APM] Make fleet optional again: Inject API key into APM Integration policy #146368

sorenlouv opened this issue Nov 28, 2022 · 2 comments · Fixed by #147650
Labels
apm:fleet apm:release-feature APM UI - Release Feature Goal apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v8.7.0

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Nov 28, 2022 •
edited
Loading

Pitch: https://github.com/elastic/apm-dev/issues/852 (internal)
Related: #146367

APM currently requires Fleet for powering several APM-specific features. To make Fleet optional we need to replicate those features.

Inject API key

Instead of retrieving source maps via fleet APM Server should query the new source map index and the agent configurations directly.

APM Server does not have access to these indicies by default. Therefore we will need to inject an API key into the APM integration policies with the needed privileges.
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 28, 2022
@sorenlouv sorenlouv added Team:APM All issues that need APM UI Team support apm:release-feature APM UI - Release Feature Goal v8.7.0 labels Nov 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 28, 2022
@sorenlouv sorenlouv added apm:fleet needs-team Issues missing a team label labels Nov 28, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 28, 2022
@simitt simitt mentioned this issue Nov 29, 2022
Closed
@sorenlouv sorenlouv changed the title Make fleet optional again: Inject API key into APM Integration policy [APM] Make fleet optional again: Inject API key into APM Integration policy Nov 30, 2022
@sorenlouv sorenlouv self-assigned this Dec 15, 2022
@sorenlouv sorenlouv mentioned this issue Dec 15, 2022
Merged
sorenlouv added a commit that referenced this issue Jan 11, 2023
@sorenlouv
[APM] Add api key to APM package policies (#147650)
96b7629 
Closes #146368
Depends on: #148509

This adds an api key to every APM package policy. This will make it
possible for APM Server to query the source map index (
`.apm-source-map` ) and the agent config index
(`.apm-agent-configuration`)
jennypavlova pushed a commit to jennypavlova/kibana that referenced this issue Jan 13, 2023
@sorenlouv @jennypavlova
[APM] Add api key to APM package policies (elastic#147650)
5b07c84 
Closes elastic#146368
Depends on: elastic#148509

This adds an api key to every APM package policy. This will make it
possible for APM Server to query the source map index (
`.apm-source-map` ) and the agent config index
(`.apm-agent-configuration`)
@sorenlouv sorenlouv removed their assignment Feb 27, 2023
@sorenlouv
Copy link
Member Author

I verified that the api keys are located into the config and are valid to retrieve source maps and agent configs

@sorenlouv sorenlouv added the apm:test-plan-done Pull request that was successfully tested during the test plan label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
apm:fleet apm:release-feature APM UI - Release Feature Goal apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Add api key to APM package policies sorenlouv/kibana
3 participants
@sorenlouv @gbamparop @elasticmachine