Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embedded Lens] Migrate all usages of EuiPage*_Deprecated #161423

Closed
Tracked by #161872
cee-chen opened this issue Jul 7, 2023 · 4 comments · Fixed by #161437
Closed
Tracked by #161872

[Embedded Lens] Migrate all usages of EuiPage*_Deprecated #161423

cee-chen opened this issue Jul 7, 2023 · 4 comments · Fixed by #161437
Assignees
@stratoula
Labels
deprecation_warnings EUI impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@cee-chen
Copy link
Member

cee-chen commented Jul 7, 2023

👋 Hello from your friendly neighborhood EUI team! It's been almost a year since EUI's new EuiPageTemplate came out (if you can believe it), which means we're about a month away from the old deprecated EUI page template components being permanently removed.

Your team is being pinged in this issue because you have a few usages of EuiPage*_Deprecated components, which you can find listed here:

How

  • Please see our new EuiPageTemplate guidelines and examples for suggestions on how to migrate over.
  • You can also see more examples of layout conversions in the original EuiPageTemplate PR:
    [Feature] EuiPage and EuiPageTemplate Updates eui#5768
  • Here's a quick conversion map of components that approximately translate to their new equivalents:
    • EuiPageTemplate_Deprecated -> EuiPageTemplate
    • EuiPageSideBar_Deprecated -> EuiPageSidebar or EuiPageTemplate.Sidebar
    • EuiPageContent_Deprecated -> EuiPageSection or EuiPageTemplate.Section
    • EuiPageContentBody_Deprecated -> Use EuiPageSection instead
    • EuiPageContentHeader_Deprecated -> Use EuiPageHeader instead
    • EuiPageContentHeaderSection_Deprecated -> Use EuiPageHeader instead

When

We'd really appreciate it if you could migrate your component usages over before or during August if possible.

If your team does not have the ability or bandwidth to perform this work by that time, please let us know. While we'd really appreciate as many teams as possible taking on this work so we're not having to touch hundreds of files by ourselves and in one go, the EUI team can potentially help you out - but we will need you to help QA that work and ensure your layouts look the same as before.

Thanks, and please feel free to reach out anytime with questions or help with migration!
@cee-chen cee-chen added Team:Visualizations Visualization editors, elastic-charts and infrastructure deprecation_warnings EUI labels Jul 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@stratoula
Copy link
Contributor

@cee-chen this seems pretty straightforward to me. I will add it to our 8.10 roadmap

@stratoula stratoula added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Jul 7, 2023
@stratoula stratoula self-assigned this Jul 7, 2023
@stratoula stratoula mentioned this issue Jul 7, 2023
Merged
stratoula added a commit that referenced this issue Jul 7, 2023
@stratoula
[Lens playground] Removes deprecated eui components (#161437)
3b67450 
## Summary

Closes #161423

Removes the deprecated EUI components.
@cee-chen
Copy link
Member Author

cee-chen commented Jul 7, 2023

@stratoula 😍 Looking amazing!! Thank you for the blazing fast response!

@petrklapka petrklapka mentioned this issue Jul 13, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stratoula stratoula

Labels
deprecation_warnings EUI impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens playground] Removes deprecated eui components stratoula/kibana
3 participants
@cee-chen @elasticmachine @stratoula