Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/canvas/datasource·ts - Canvas Canvas app datasource "before all" hook in "datasource" #163368

Closed
kibanamachine opened this issue Aug 8, 2023 · 1 comment · Fixed by #164376
Closed

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/canvas/datasource·ts - Canvas Canvas app datasource "before all" hook in "datasource" #163368

kibanamachine opened this issue Aug 8, 2023 · 1 comment · Fixed by #164376
Assignees
@cqliu1
Labels
failed-test A test failure on a tracked branch, potentially flaky-test impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@kibanamachine
Copy link
Contributor

A test failed on a tracked branch

Error: retry.tryForTime timeout: Error: retry.try timeout: Error: App failed to load: canvas in 10000ms appUrl=http://localhost:5620/app/canvas#/ currentUrl=http://localhost:5620/app/canvas/
    at common_page.ts:294:17
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at runAttempt (retry_for_success.ts:29:15)
    at retryForSuccess (retry_for_success.ts:68:21)
    at RetryService.try (retry.ts:31:12)
    at common_page.ts:252:21
    at runAttempt (retry_for_success.ts:29:15)
    at retryForSuccess (retry_for_success.ts:68:21)
    at RetryService.tryForTime (retry.ts:22:12)
    at CommonPageObject.navigateToApp (common_page.ts:251:5)
    at Context.<anonymous> (datasource.ts:38:7)
    at Object.apply (wrap_function.js:73:16)
    at onFailure (retry_for_success.ts:17:9)
    at retryForSuccess (retry_for_success.ts:59:13)
    at RetryService.try (retry.ts:31:12)
    at common_page.ts:252:21
    at runAttempt (retry_for_success.ts:29:15)
    at retryForSuccess (retry_for_success.ts:68:21)
    at RetryService.tryForTime (retry.ts:22:12)
    at CommonPageObject.navigateToApp (common_page.ts:251:5)
    at Context.<anonymous> (datasource.ts:38:7)
    at Object.apply (wrap_function.js:73:16)
    at onFailure (retry_for_success.ts:17:9)
    at retryForSuccess (retry_for_success.ts:59:13)
    at RetryService.tryForTime (retry.ts:22:12)
    at CommonPageObject.navigateToApp (common_page.ts:251:5)
    at Context.<anonymous> (datasource.ts:38:7)
    at Object.apply (wrap_function.js:73:16)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Aug 8, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 8, 2023
@kibanamachine kibanamachine added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Aug 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 8, 2023
@Heenawter Heenawter mentioned this issue Aug 8, 2023
Closed
@Heenawter Heenawter added the impact:critical This issue should be addressed immediately due to a critical level of impact on the product. label Aug 9, 2023
@cqliu1 cqliu1 mentioned this issue Aug 21, 2023
Merged
9 tasks
cqliu1 added a commit that referenced this issue Sep 19, 2023
@cqliu1
[Canvas] Fix flaky test failures when navigating to Canvas app (#164376)
94587c9 
## Summary

Closes #163303.
Closes #163368.
Closes #163903.

This fixes a rarely occurring flaky test failure while navigating to the
Canvas app where the `currentURL` check fails. The cause is
`navigateToApp` goes to `app/canvas#/` which includes a hash get
redirected by the Canvas app to `app/canvas/`, and fails when
`app/canvas/` doesn't match `app/canvas#/`. I've chosen to disable this
check when navigating to Canvas to avoid this flakiness because I
couldn't remove the hash from the URL while using `navigateToApp` or
`navigateToURL`.

Instead of checking the URLs match, I opted to check that the workpad
listing page loaded correctly.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cqliu1 cqliu1

Labels
failed-test A test failure on a tracked branch, potentially flaky-test impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Canvas] Fix flaky test failures when navigating to Canvas app cqliu1/kibana
4 participants
@cqliu1 @Heenawter @elasticmachine @kibanamachine