Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard Navigation] Fix links panel in Canvas #164114

Closed
Tracked by #154354
Heenawter opened this issue Aug 16, 2023 · 3 comments
Closed
Tracked by #154354

[Dashboard Navigation] Fix links panel in Canvas #164114

Heenawter opened this issue Aug 16, 2023 · 3 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Dashboard Navigation Related to the Dashboard Navigation Project Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Heenawter
Copy link
Contributor

Heenawter commented Aug 16, 2023

Describe the issue:

Currently, the Links panel is available in the "Select type" dropdown for Canvas but, on adding it, the flyout does not open and you cannot edit the resulting embeddable. We should either:

  1. Figure out why this is happening and fix it or
  2. Disable the links panel in Canvas

I am a bit worried that, if the links panel is available + editable in Canvas, users might not understand that it is designed specifically for dashboard navigation (at least for now) and will not support links to different Canvas workpads (for example). For that reason, I am leaning towards simply disabling the links panel for now - hence, the smaller LOE. However, this is worth a larger discussion.

@Heenawter Heenawter added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Aug 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter added the Project:Dashboard Navigation Related to the Dashboard Navigation Project label Aug 16, 2023
@ThomThomson
Copy link
Contributor

+1 to just disabling it in Canvas.

@nickpeihl nickpeihl self-assigned this Aug 31, 2023
@Heenawter Heenawter added the Feature:Dashboard Dashboard related features label Aug 31, 2023
nickpeihl added a commit that referenced this issue Sep 5, 2023
Fixes #164114

## Summary

Disables the new Links panel in Canvas. 

Links panel is a dashboard only feature. Canvas does not have any use
for the Links panels. Canvas supports adding multiple pages to a workpad
which offers a similar functionality.
@nickpeihl
Copy link
Member

Fixed by #164330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Dashboard Navigation Related to the Dashboard Navigation Project Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

4 participants