Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability Onboarding] Search results not cleared with search term #180821

Closed
thomheymann opened this issue Apr 15, 2024 · 1 comment · Fixed by #180979
Closed

[Observability Onboarding] Search results not cleared with search term #180821

thomheymann opened this issue Apr 15, 2024 · 1 comment · Fixed by #180979
Assignees
@justinkambic
Labels
Team:obs-ux-logs Observability Logs User Experience Team

Comments

@thomheymann
Copy link
Contributor

Clearing the search term field currently shows all available integrations.

Instead we should clear the grid and show no integrations until a search term is entered again.

clear-grid-bug.mov
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 15, 2024
@dej611 dej611 added the Team:obs-ux-logs Observability Logs User Experience Team label Apr 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 16, 2024
@justinkambic justinkambic mentioned this issue Apr 16, 2024
Merged
@justinkambic justinkambic self-assigned this Apr 17, 2024
flash1293 added a commit that referenced this issue Apr 22, 2024
@justinkambic @flash1293
[Observability Onboarding] Hide integrations grid when search term is…
8aa7606 
… cleared (#180979)

## Summary

Resolves #180821.
Resolves #180813.
Resolves [#180811](#180811).

As noted in the linked issue, we want to clear the integrations list
whenever the search bar's query is empty.

### Testing

You should see the list disappear whenever the search query is empty.
Collection selection and user-entered queries should continue to operate
normally.

### Note

A possible area of improvement is the janky behavior when clearing a
large list, or as the user is entering a query. This is captured a bit
in the attached GIF. I played with using the `visibility` property of
the list's container but this has the opposite negative side effect of
causing the page to stay very large when the list is hidden.


![20240416162832](https://github.com/elastic/kibana/assets/18429259/d8f01ec5-5cfa-42c3-9e30-a7c1dcf0dd37)

---------

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinkambic justinkambic

Labels
Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Observability Onboarding] Hide integrations grid when search term is cleared justinkambic/kibana
4 participants
@thomheymann @dej611 @elasticmachine @justinkambic