Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility] Regression in the Roles UI Combo Boxes #27749

Open
aphelionz opened this issue Dec 23, 2018 · 4 comments
Open

[Accessibility] Regression in the Roles UI Combo Boxes #27749

aphelionz opened this issue Dec 23, 2018 · 4 comments
Assignees
@jeramysoucy
Labels
Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Users/Roles/API Keys Project:Accessibility Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! WCAG A

Comments

@aphelionz
Copy link
Contributor

Steps to reproduce (assumes ChromeVox or similar)

  1. Open /app/kibana#/management/security/roles
  2. Tab throughout all combo boxes on the firms.

screenshot_20181223_120914

Actual Result
3. Combo boxes lack adequate screen reader labeling

Expected Result
4. Combo Boxes should announce proper labeling

Kibana Version: 6.5
Relevant WCAG Criteria: 3.3.2 Labels or Instructions https://www.w3.org/WAI/WCAG21/quickref/#labels-or-instructions
Meta Issue: #18051
@aphelionz aphelionz added Project:Accessibility Feature:Users/Roles/API Keys Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages labels Dec 23, 2018
@bhavyarm bhavyarm added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Dec 27, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@kobelb
Copy link
Contributor

kobelb commented Jan 2, 2019

I see the aria-label attribute being added to these controls, and EUI is specifying them. Any guidance what should be changed?

@aphelionz
Copy link
Contributor Author

I'm not sure without looking at the EUI code but I think reviewing it with VoiceOver or ChromeVox should clarify what I mean - they should be announcing "Cluster Privileges", "Run As privileges" etc...

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Aug 5, 2021
@legrego legrego removed EnableJiraSync loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Aug 18, 2022
@jeramysoucy jeramysoucy self-assigned this Mar 24, 2023
This was referenced Mar 27, 2023
Open
Merged
@jeramysoucy
Copy link
Contributor

PR #153808 addresses the issues here regarding missing aria-labels and announcement of options, however, until the EuiComboBox rebuild is complete I do not believe we can resolve the main issue of announcement of the combo boxes' labels.

jeramysoucy added a commit that referenced this issue Mar 30, 2023
@jeramysoucy
Improves screen reader features of combo boxes in edit role screen (#…
b3d78e8 
…153808)

## Summary

Related to #27749

While the [EuiComboBox
rebuild](elastic/eui#2841) is in progress,
this PR addresses missing aria properties and fixes option announcements
for the `run as user` combo. It additionally adds an aria-label for the
Spaces Navigation EuiSelectable that I found was missing.

### Testing
- Add all sample data
- Edit a non-reserved role
- Turn on a screen reader (NVDA is recommended, but VoiceOver will do)
- Tab through the controls on the Edit role screen. When you arrive in a
combo box you may or may not hear an announcement declaring the name of
the combo box (this is expected, especially with VoiceOver).
- With focus in a combo box press the down arrow key. Verify the options
are announced as you traverse them with the down and up arrow keys.
- If there was success in option announcement, press escape key and
verify that the name of the combo box is announced. You may have to
press escape twice when using NVDA.

Note: It seems to be the consensus that this is best we can do with the
existing implementation of EuiComboBox, which is partly why it is being
rebuilt with the EuiSelectable component.
@JasonStoltz JasonStoltz mentioned this issue May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeramysoucy jeramysoucy

Labels
Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Users/Roles/API Keys Project:Accessibility Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! WCAG A
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@aphelionz @kobelb @legrego @bhavyarm @elasticmachine @rayafratkina @jeramysoucy