Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design adaptions of Discover's chart #45629

Closed
kertal opened this issue Sep 13, 2019 · 7 comments
Closed

Design adaptions of Discover's chart #45629

kertal opened this issue Sep 13, 2019 · 7 comments
Assignees
Labels
discuss Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@kertal
Copy link
Member

kertal commented Sep 13, 2019

Now that we're using Elastic Charts in Discover (#43788 🎉 ), it's time to discuss about possible solutions to minimize the amount of space the charts take at the top of the page. Here's the suggested solution by @mdefazio:

Chart--collapse
Chart--expand

User would have the ability to expand to show the labels/axis, etc.

  • Removes the redundant date field above the chart
  • Increases the size of the result/hit count
  • The styling of the chart is for presentation only—not suggesting a different style than EUI charts theme.

Originally posted by @mdefazio in #43788 (comment)

@AlonaNadler
Copy link

The way I see it showing a chart without the means to read it such as date, intervals, and the y-axis scale to save screen space doesn't make sense.

We heard in the past a request to hide the histogram in Discover, that has not been a common ask so, in general, I don't think it is a high priority, mainly because it doesn't prevent people from using the tool, and the histogram provides more context to most users.
However, if you still think it worth to pursue, I think a better solution will be to hide the histogram completely in order to save on space instead of the axis

@ryankeairns
Copy link
Contributor

+1 what Alona said. Let's have the button hide the entire chart, not just the labels.

@mdefazio
Copy link
Contributor

I am still working through this a bit, but thought I'd share this anyway. I have the show/hide graph updated and am getting the datagrid put in.

DiscoverUpdate

@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Mar 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@AlonaNadler
Copy link

@kertal I think there are bigger issues we should address with Discover. I feel the potential for Discover is a lot bigger and this issue currently does not strike me as a priority

@kertal
Copy link
Member Author

kertal commented Mar 6, 2020 via email

@kertal
Copy link
Member Author

kertal commented Dec 16, 2020

closing this because hiding the histogram was implemented in #83633

@kertal kertal closed this as completed Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

7 participants