-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiny UI text issue in Management > Advanced settings page (Dark mode setting) #46622
Comments
Pinging @elastic/kibana-app |
@cchaos Can you please comment on this issue? |
Yes we'd love to have dark mode be part of user settings and not buried under Advanced Settings. However, there's no architecture setup for user settings at the moment so this is the only place in can live for now. I think all the text changes are viable. Advanced settings actually falls under @elastic/kibana-app-arch. I'll change the labels. |
These are actually kind of three different issues in one. For (1) I would refer to #14791 for discussion. For (2) we can align the wording here, just would like an input from @gchaps which way we should rather go. (3) We currently show the technical default values, i.e. what’s actually saved, this would be an enhancement if we want to show default values kind of formatted |
For 2), I suggest this wording: Enable dark mode for the Kibana UI. Reload the page to apply the setting. For 3), Is the wording |
Pinging @elastic/datavis (Team:DataVis) |
Pinging @elastic/kibana-design (Team:Kibana-Design) |
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
Pinging @elastic/kibana-core (Team:Core) |
I think 1) is similar to #108723. |
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Kibana version: 7.4
Describe the bug:
ThreeOne small thing about the dark mode setting and the related text.1. The dark mode setting is currently buried near the end of the Management > Advanced settings page, and below the warning banner saying "Be careful in here, these settings are for very advanced users only." Is that really the case? Would this setting be better nearer the top where it's visible, and perhaps above the warning banner? And is it a space setting or a personal setting? I understand that it may be better left as it is if it will affect every user of the space, but I assume it's a personal setting? If it really is a space setting, it could be helpful to mention the fact.The default value is shown asfalse
but the toggle text is On/OffPerhaps one for @gchaps?The text was updated successfully, but these errors were encountered: