Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ability to pin filters in embedded dashboards #5056

Closed
fakeh opened this issue Oct 2, 2015 · 12 comments · Fixed by #10816
Closed

Remove ability to pin filters in embedded dashboards #5056

fakeh opened this issue Oct 2, 2015 · 12 comments · Fixed by #10816
Assignees

Comments

@fakeh
Copy link

fakeh commented Oct 2, 2015

Hi all,

When a Dashboard is embedded users can still pin filters, which is meaningless in this context.

Dan.

@rkhapre
Copy link

rkhapre commented Oct 8, 2015

this is useful, which is the power of kibana, discovering data and narrowing down the problem with filters, so useful in embedded dashboard as well

@marcinkubica
Copy link

-1

@fakeh
Copy link
Author

fakeh commented Oct 9, 2015

Putting it another way then, what's the meaning of a pinned filter in an embedded dashboard?

@panthony
Copy link

panthony commented Nov 9, 2015

I'm not really sure what do you mean by "embedded dashboards" as the only thing I have found on kibana is to embed a single visualization within an iframe (I may have missed something).

But in case we are embedding a single visualization I think we should have a way to disable filters.

Since the visualization is alone and out of context (not part of a dashboard) I see no value for the user to be able to filter on a specific category.

You just end up with the same chart and a single category (the one selected) and nothing else changed..

Another related issue, on histogram, is that if you filter on a category it will also apply a filter on the date range, and you have no way to go back. You must refresh the whole website you reload the iframe.

@fakeh
Copy link
Author

fakeh commented Dec 16, 2015

the only thing I have found on kibana is to embed a single visualization within an iframe (I may have missed something)

@panthony You can also embed entire dashboards. Workflow is similar.

@spalger
Copy link
Contributor

spalger commented Dec 16, 2015

@fakeh I think you make a good point. The purpose of pinning a filter is so it will follow you from dashboard to discover and so on. On an embedded dashboard though it has no effect as the embedded mode aims to prevent you from leaving dashboard.

@spalger spalger added the good first issue low hanging fruit label Dec 16, 2015
@rkhapre
Copy link

rkhapre commented Feb 5, 2016

@rashidkpc
In Kibana 4.3.1, the pinfilters is removed from one Dashboard to another Dashboard.

In previous releases the pinfilter was working very well

This was the main theme of Kibana dashboard where we can pin the data in one Dashboard and go to other Dashboard to see a different visualization. This feature was very powerful, not sure why other folks in forums is opposing it.

I can explain 4-5 use cases where this is used in many organizations

Please let me know if there is any workaround on this?

@marcinkubica
Copy link

@rkhapre I can see pinning still works between dashboards. Ie, I can pin a filter and open different dashboard and pinned filter is retained.

What I find not useful is state of filter pinned is not being saved with the dashboard.

stacey-gammon added a commit to stacey-gammon/kibana that referenced this issue Mar 20, 2017
It doesn’t make sense there, since there won’t be any cross app
navigation, so don’t expose it.

fixes elastic#5056
stacey-gammon added a commit to stacey-gammon/kibana that referenced this issue Mar 22, 2017
It doesn’t make sense there, since there won’t be any cross app
navigation, so don’t expose it.

fixes elastic#5056
stacey-gammon added a commit to stacey-gammon/kibana that referenced this issue Mar 22, 2017
It doesn’t make sense there, since there won’t be any cross app
navigation, so don’t expose it.

fixes elastic#5056
stacey-gammon added a commit to stacey-gammon/kibana that referenced this issue Mar 23, 2017
It doesn’t make sense there, since there won’t be any cross app
navigation, so don’t expose it.

fixes elastic#5056
stacey-gammon added a commit to stacey-gammon/kibana that referenced this issue Mar 27, 2017
It doesn’t make sense there, since there won’t be any cross app
navigation, so don’t expose it.

fixes elastic#5056
stacey-gammon added a commit to stacey-gammon/kibana that referenced this issue Mar 28, 2017
It doesn’t make sense there, since there won’t be any cross app
navigation, so don’t expose it.

fixes elastic#5056
stacey-gammon added a commit to stacey-gammon/kibana that referenced this issue Mar 29, 2017
It doesn’t make sense there, since there won’t be any cross app
navigation, so don’t expose it.

fixes elastic#5056
stacey-gammon added a commit that referenced this issue Mar 29, 2017
* Hide pinned filter state in embed mode

It doesn’t make sense there, since there won’t be any cross app
navigation, so don’t expose it.

fixes #5056

* Also conditionally hide "all filter" pin state actions
elastic-jasper added a commit that referenced this issue Mar 29, 2017
Backports PR #10816

**Commit 1:**
Hide pinned filter state in embed mode

It doesn’t make sense there, since there won’t be any cross app
navigation, so don’t expose it.

fixes #5056

* Original sha: db3b881
* Authored by Stacey Gammon <gammon@elastic.co> on 2017-03-20T17:05:21Z

**Commit 2:**
Also conditionally hide "all filter" pin state actions

* Original sha: 6314e43
* Authored by Stacey Gammon <gammon@elastic.co> on 2017-03-28T20:44:44Z
stacey-gammon pushed a commit that referenced this issue Mar 30, 2017
Backports PR #10816

**Commit 1:**
Hide pinned filter state in embed mode

It doesn’t make sense there, since there won’t be any cross app
navigation, so don’t expose it.

fixes #5056

* Original sha: db3b881
* Authored by Stacey Gammon <gammon@elastic.co> on 2017-03-20T17:05:21Z

**Commit 2:**
Also conditionally hide "all filter" pin state actions

* Original sha: 6314e43
* Authored by Stacey Gammon <gammon@elastic.co> on 2017-03-28T20:44:44Z
@stacey-gammon
Copy link
Contributor

@spalger Re:

@fakeh I think you make a good point. The purpose of pinning a filter is so it will follow you from dashboard to discover and so on. On an embedded dashboard though it has no effect as the embedded mode aims to prevent you from leaving dashboard.

@robacj Brought up a good point on the PR that pinned state matters when moving from dashboard to another dashboard, which they are using in embedded mode, with the use of dashboard navigation in a markdown widget.

I'm tempted to just revert the PR since it was supposed to be low fruit and was not a high priority item. Since it turns out there were use cases I wasn't aware of, we will actually be removing functionality that some people may rely on.

cc @Bargs

@stacey-gammon stacey-gammon reopened this Apr 4, 2017
@spalger
Copy link
Contributor

spalger commented Apr 5, 2017

Sounds like the best way to solve this is actually #9575

@stacey-gammon
Copy link
Contributor

Agree with @spalger that this belongs as an option under #9575

Will close in favor of that, but link to this issue to keep track of this specific feature request.

@Kolano
Copy link

Kolano commented May 9, 2019

What's really needed is to alternately store pinned filters to allow them to work across separate dashboard iframes; not only when using navigation internal to a dashboard.

While we wait for #9575, injecting this style addresses hiding the broken pinning button...

/*Hide broken filter pinning button*/
button[data-test-subj="pinFilter"], button[data-test-subj="pinAllFilters"], button[data-test-subj="unpinAllFilters"]{
	display: none;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants