Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Firefox XPack UI Functional Tests.x-pack/test/functional/apps/infra/link_to·ts - InfraOps app Infra link-to redirects to the logs app and parses URL search params correctly #55652

Closed
kibanamachine opened this issue Jan 23, 2020 · 9 comments · Fixed by #56329
Assignees
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services triage_needed

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 23, 2020

A test failed on a tracked branch

Error: retry.tryForTime timeout: Error: expected 'logFilter=(expression:\'trace.id:433b4651687e18be2c6c8e3b11f53d09\',kind:kuery)&logPosition=(position:(tiebreaker:0,time:1565707203194))&sourceId=default' to contain 'logFilter=(expression:\'trace.id:433b4651687e18be2c6c8e3b11f53d09\',kind:kuery)&logPosition=(position:(tiebreaker:0,time:1565707203194),streamLive:!f)&sourceId=default'
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.contain (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:442:10)
    at retry.tryForTime (test/functional/apps/infra/link_to.ts:37:67)
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at onFailure (/dev/shm/workspace/kibana/test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (/dev/shm/workspace/kibana/test/common/services/retry/retry_for_success.ts:68:13)

First failure: Jenkins Build

@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jan 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage (failed-test)

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@brianseeders brianseeders added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services triage_needed labels Jan 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@brianseeders
Copy link
Contributor

@weltenwort
Copy link
Member

@Zacqary could this be related to the log position state refactoring?

@Zacqary
Copy link
Contributor

Zacqary commented Jan 28, 2020

@weltenwort Yes, I noticed that the URL seemed to be including the streamLive:!f flag when it previously hadn't been before the refactor. Now it seems like it's gone back to not including that flag. I'll investigate and see if I can figure out why it's inconsistent.

@Zacqary Zacqary self-assigned this Jan 28, 2020
@weltenwort
Copy link
Member

thank you - maybe it's just a timing issue, meaning the test checks too early for it to be included. in that case a retry.try might be an easy way to stabilize

@Zacqary
Copy link
Contributor

Zacqary commented Jan 29, 2020

I've decided to just remove the possibility of having streamLive:!f in the URL and only make it set it to streamLive:!t when it's true, which I believe is how the URL state worked before the refactor. The streamLive param will now only be present if it's true and absent if it's false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services triage_needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants